<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128734/">https://git.reviewboard.kde.org/r/128734/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Wojniłowicz.</div>
<p style="color: grey;"><i>Updated Sept. 3, 2016, 9:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 8ae1ebcbe7d59058cc39ece143efa3197fc7565e by ?ukasz Wojni?owicz to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) slotFileDialogClicked was duplicated in csvdialog.cpp and
investprocessing.cpp so moved it to csvwizard.cppp,
2) introduced getInFileName for asking user about his statement file,
3) createProfile, editProfileName, addProfileName was complicated and
replaced by single shorter profileTypeChanged
4) slotRadioButton_bankClicked and slotRadioButton_investClicked was
complicted and replaced by profileTypeChange
5) adding/removing/renaming profile was not user friendly and
informative so new buttons added,
6) no need to have template csvimporterrc, all can be done through
validateConfigFile
7) cleaned up csvimporterrc so its more informative and easier to get
data from it,
8) introduced updateConfigFile which is framework for migrating
csvimporterrc file between different KMM versions,
9) removed enableInputs as it wasn't doing anything usefull,
10) introduced m_config which allows asking for configuration file only
once at the beginning,
11) removed lots of redundant variables.</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">new csvimporterrc schema</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[Bank-a1]
Directory=~/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[Invest-a1]
Directory=~/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[Misc]
Height=400
KMMVer=5,0,0
Width=800</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[ProfileNames]
Bank=a1
Invest=a1
PriorBank=
PriorInvest=</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[Securities]
SecurityNameList=</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/csvdialog.h <span style="color: grey">(ef7ba53)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.cpp <span style="color: grey">(859cdc2)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.h <span style="color: grey">(cbc70fb)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.cpp <span style="color: grey">(3ff38ed)</span></li>
<li>kmymoney/plugins/csvimport/introwizardpage.ui <span style="color: grey">(a91a737)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.h <span style="color: grey">(9374212)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(c306173)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128734/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/22/855272f4-8710-4790-902e-5bba44c37739__intro_page.png">intro page.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>