<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128695/">https://git.reviewboard.kde.org/r/128695/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Wojniłowicz.</div>
<p style="color: grey;"><i>Updated Aug. 22, 2016, 7:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit d52980d06dbf44badc32a9d5f49f14ed6d658b7e by ?ukasz Wojni?owicz to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) processInvestLine should identify fields by integers and not strings
(better performance),
2) processing of type, symbol, name fields contains unnecessary code
and m_brokerage isn't doing anything usefull,
3) type field needs amount, price, quanity so process them first
4) QIF creation is not essential to processing (less memory),
5) QList statements is not needed and consumed memory exponentially,
6) investCsvImport doesn't do anything usefull besides copying data from
processInvestLine so merge both,
7) transaction types should be identified by enum from
MyMoneyStatement::Transaction,
8) redefinedlg.cpp contains duplicate code,
9) validation of selected column contains duplicate code,
10) new QMaps: m_colTypeNum, m_colNumType, m_colTypeName for handling
columns information,
11) validateMemoComboBox for validating copied memo field,
12) csvSplit not needed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/csvwizard.cpp <span style="color: grey">(435006b)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.h <span style="color: grey">(27cea07)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(e20c1de)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlg.h <span style="color: grey">(e242d62)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlg.cpp <span style="color: grey">(8afa4ad)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128695/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>