<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128411/">https://git.reviewboard.kde.org/r/128411/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 20th, 2016, 8:19 a.m. CEST, <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have done a visual inspection of the code parts. They look good to me.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Good. Thanks for reviewing. Notable change that I made in actual commit is that I've moved updateWindowSize function to csvwizard.cpp (less code added in the end) and I think it should be the way to go when rewriting CSV importer code i.e. move all alike/duplicate functions from csvdialog.cpp and investprocessing.cpp to csvwizard.cpp.</p></pre>
<br />
<p>- Łukasz</p>
<br />
<p>On July 16th, 2016, 5:36 p.m. CEST, Łukasz Wojniłowicz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Wojniłowicz.</div>
<p style="color: grey;"><i>Updated July 16, 2016, 5:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Result: <a href="http://i.imgur.com/ZkvSFce.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">CSVWizard</a>
1) integrated tableWidget into CSVWizard,
2) removed separate window holding tableWidget,
3) modified some .ui files, so tableWidget gets the most space while resizing CSVWizard,
4) removed hardcoded values for HiDPI support; that functionality can be easier achieved with policies in QtDesigner
5) CSVWizar doesn't stay forever after import without setup,
6) tableWidget gets resized to fit content and not exceed screen area,
7) simplified completion page.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think csvdialog.ui could be deleted as it isn't needed anymore.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Banking and investment statement CSV imports; with and without setup.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/bankingwizardpage.ui <span style="color: grey">(95e5276)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.h <span style="color: grey">(d226665)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.cpp <span style="color: grey">(4fff108)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterplugin.cpp <span style="color: grey">(b58ed84)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.h <span style="color: grey">(0bf1e59)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.cpp <span style="color: grey">(39bf9f2)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.ui <span style="color: grey">(5c42f46)</span></li>
<li>kmymoney/plugins/csvimport/investmentdlg.cpp <span style="color: grey">(514bff3)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.h <span style="color: grey">(15cba5e)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(e0d2b8f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128411/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>