<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127680/">https://git.reviewboard.kde.org/r/127680/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 26th, 2016, 8:04 p.m. UTC, <b>Christian David</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I did not test it. Since <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KDialog</code> is deprecated I am okay with this change. Also this was done for the frameworks branch already (which is important for me).</p></pre>
</blockquote>
<p>On April 26th, 2016, 10:32 p.m. UTC, <b>Mitch Frazier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This has the wrong diff (this is the diff for #127679).</p></pre>
</blockquote>
<p>On April 26th, 2016, 10:42 p.m. UTC, <b>Mitch Frazier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Trying to update the diff, but reviewboard says the file can't be parsed. Ran into this problem before but have forgotten the workaround, will update when my memory returns...</p></pre>
</blockquote>
<p>On April 26th, 2016, 11:33 p.m. UTC, <b>Mitch Frazier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If memory serves me it's a known error with reviewboard.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See https://www.mail-archive.com/reviewboard@googlegroups.com/msg15800.html for example:</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is a known issue with the tool when the branch isn't up-to-date with
regard to its tracking branch. We're working on a set of improvements to this
logic that will hopefully resolve this.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But I've tried updating my repo and rebasing my branch, which is what I'm pretty sure fixed it the last time I had this problem. But so far this hasn't fixed it... Perhaps there are some bits caught in the Ether, I'll try it again later.</p></pre>
</blockquote>
<p>On April 27th, 2016, 12:51 a.m. UTC, <b>Mitch Frazier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Although the known problem above does produce the same error, this is a different variation: this appears instead to be due to the fact that the patch changes one of the same files that's included in the change for review request #127679, which has not yet been committed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If I try to add the patch to a new review request I get the following error from reviewboard:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">The specified diff file could not be parsed.
Line undefined: fatal: git cat-file 6e6a955d959a06b7aa0e30ba854a360f62b61fa3: bad file
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If I do this:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">git cat-file -p 6e6a955d959a06b7aa0e30ba854a360f62b61fa3
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">in my copy of the repo it shows me the file in question. If I do it in a clean clone of the repo I get:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">fatal<span style="color: #666666">:</span> Not a valid object name <span style="color: #666666">6</span>e6a955d959a06b7aa0e30ba854a360f62b61fa3
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I could attach the file directly or wait till a decision is made on #127679.</p></pre>
</blockquote>
<p>On April 27th, 2016, 7:21 p.m. UTC, <b>Cristian Oneț</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Christian David KDialog is only deprecated in frameworks, on KDE4 we should keep KDialog, that is why I asked against which branch is this pathch.</p></pre>
</blockquote>
<p>On April 27th, 2016, 9:02 p.m. UTC, <b>Mitch Frazier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The KDialog change is actually #127679, the attached patch is actually for that review item. That said, the change only changes KDialog to QDialog on the Qt Designer .ui files, the dialogs themselves continue to be KDialog. The problem is that KDialog does not play well with Qt Designer and so if you open a KDialog .ui file in Qt Designer, it's all messed up and not very editable.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One of the things that I noticed was that most of the dialogs are defined as QDialog and have OK and Cancel buttons specifically added to them, perhaps because using KDialog causes problems with Qt Designer.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Going to copy these last few comments over to the other review item also.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OK, then ship it.</p></pre>
<br />
<p>- Cristian</p>
<br />
<p>On April 22nd, 2016, 3 p.m. UTC, Mitch Frazier wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Mitch Frazier.</div>
<p style="color: grey;"><i>Updated April 22, 2016, 3 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some custom-widgets specified the wrong class that was being
extended by the widget causing warnings when opening the file
with Qt Designer.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These warnings only occur when using the kmymoneywidgets.so plugin
library for Qt Designer.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested a couple of the dialogs.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/kcurrencycalculatordecl.ui <span style="color: grey">(0bcfd4060338d8659979f8372269fba64f05c6ab)</span></li>
<li>kmymoney/dialogs/kcurrencyeditdlgdecl.ui <span style="color: grey">(1527455a3201ba91c50bee572bc747bba59cd89a)</span></li>
<li>kmymoney/dialogs/kfindtransactiondlg.cpp <span style="color: grey">(76030075141afe04a7aea23a06617be77cf1721d)</span></li>
<li>kmymoney/dialogs/kfindtransactiondlgdecl.ui <span style="color: grey">(44fa86190d035c4652fa9b8129478f6cfcfd6d47)</span></li>
<li>kmymoney/dialogs/kmymoneypricedlgdecl.ui <span style="color: grey">(a484504c32f3313d1d6a37551be10f74485ec1d2)</span></li>
<li>kmymoney/dialogs/ksortoptiondlg.ui <span style="color: grey">(e7e28e588323b116c5874ad4ac3fee2c28663788)</span></li>
<li>kmymoney/dialogs/ksplitcorrectiondlg.ui <span style="color: grey">(fb6d337e746e7d2b5a9b5d355dae46a5dae369bc)</span></li>
<li>kmymoney/dialogs/ksplittransactiondlgdecl.ui <span style="color: grey">(6b1c706a69ab0a289426fbd894068563dcf93e26)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127680/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>