<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">I marked the review request as submitted, I don't have commit access so somebody needs to actually commit it.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 5, 2016 at 6:32 AM, Cristian Oneț <span dir="ltr"><<a href="mailto:onet.cristian@gmail.com" target="_blank">onet.cristian@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">



 <div>
  <div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><span class="">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border:1px #c9c399 solid;border-radius:6px">
    <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127680/" target="_blank">https://git.reviewboard.kde.org/r/127680/</a>
     </td>
    </tr>
   </tbody></table>
   <br>



</span><p>

Ship it!

</p>



 <pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Ship It!</pre><span class="HOEnZb"><font color="#888888">
 <br>









<p>- Cristian Oneț</p></font></span><span class="">


<br>
<p>On April 22nd, 2016, 3 p.m. UTC, Mitch Frazier wrote:</p>








</span><span class=""><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border:1px #888a85 solid;border-radius:6px">
 <tbody><tr>
  <td>

<div>Review request for KMymoney.</div>
<div>By Mitch Frazier.</div>


<p style="color:grey"><i>Updated April 22, 2016, 3 p.m.</i></p>









<div style="margin-top:1.5em">
 <b style="color:#575012;font-size:10pt">Repository: </b>
kmymoney
</div>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Some custom-widgets specified the wrong class that was being
extended by the widget causing warnings when opening the file
with Qt Designer.</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">These warnings only occur when using the kmymoneywidgets.so plugin
library for Qt Designer.</p></pre>
  </td>
 </tr>
</tbody></table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Tested a couple of the dialogs.</p></pre>
  </td>
 </tr>
</tbody></table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">

 <li>kmymoney/dialogs/kcurrencycalculatordecl.ui <span style="color:grey">(0bcfd4060338d8659979f8372269fba64f05c6ab)</span></li>

 <li>kmymoney/dialogs/kcurrencyeditdlgdecl.ui <span style="color:grey">(1527455a3201ba91c50bee572bc747bba59cd89a)</span></li>

 <li>kmymoney/dialogs/kfindtransactiondlg.cpp <span style="color:grey">(76030075141afe04a7aea23a06617be77cf1721d)</span></li>

 <li>kmymoney/dialogs/kfindtransactiondlgdecl.ui <span style="color:grey">(44fa86190d035c4652fa9b8129478f6cfcfd6d47)</span></li>

 <li>kmymoney/dialogs/kmymoneypricedlgdecl.ui <span style="color:grey">(a484504c32f3313d1d6a37551be10f74485ec1d2)</span></li>

 <li>kmymoney/dialogs/ksortoptiondlg.ui <span style="color:grey">(e7e28e588323b116c5874ad4ac3fee2c28663788)</span></li>

 <li>kmymoney/dialogs/ksplitcorrectiondlg.ui <span style="color:grey">(fb6d337e746e7d2b5a9b5d355dae46a5dae369bc)</span></li>

 <li>kmymoney/dialogs/ksplittransactiondlgdecl.ui <span style="color:grey">(6b1c706a69ab0a289426fbd894068563dcf93e26)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127680/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>






  </td>
 </tr>
</tbody></table>







  </span></div>
 </div>


</blockquote></div><br></div>