<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127679/">https://git.reviewboard.kde.org/r/127679/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 26th, 2016, 8:06 p.m. UTC, <b>Christian David</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What is the differece to review request #127680?</p></pre>
</blockquote>
<p>On April 26th, 2016, 10:29 p.m. UTC, <b>Mitch Frazier</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oops, looks like I added the wrong diff onto #127680 (the same one as here).</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Confusion here due to the patch problem on #127680. On there, Christian said "KDialog is only deprecated in frameworks, on KDE4 we should keep KDialog, that is why I asked against which branch is this patch."</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My response was (edited):</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch only changes KDialog to QDialog in the Qt Designer .ui files, the dialogs themselves continue to be KDialog. The problem is that KDialog does not play well with Qt Designer and so if you open a KDialog .ui file in Qt Designer, it's all messed up and not very editable.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One of the things that I noticed was that most of the dialogs in KMyMoney are defined as QDialog and have OK and Cancel buttons specifically added to them, perhaps because using KDialog causes problems with Qt Designer.</p></pre>
<br />
<p>- Mitch</p>
<br />
<p>On April 22nd, 2016, 3 p.m. UTC, Mitch Frazier wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Mitch Frazier.</div>
<p style="color: grey;"><i>Updated April 22, 2016, 3 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDialog does not work well with Qt Designer.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Changing the widget class from KDialog to QDialog is generally
all that's required. Even though changing from KDialog to
QDialog does remove the OK and Cancel buttons in Designer,
these are added automatically because the dialog class itself
is still KDialog and it by default adds these buttons.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One of the dialogs did require the adding of a setButtons() call
to the constructor to place additional buttons on the dialog
that were previously specified in the .ui file.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Before and after screenshots show what the kfindtransactiondlgdecl.ui
file looks like in Qt Designer before with KDialog and after with QDialog.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note that one of the dialogs, ksplittransactiondlgdecl.ui appears to
be unused and can probably be deleted, although I did not test that.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested the affected dialogs for correct look and function.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/kcurrencycalculatordecl.ui <span style="color: grey">(0bcfd40)</span></li>
<li>kmymoney/dialogs/kcurrencyeditdlgdecl.ui <span style="color: grey">(1527455)</span></li>
<li>kmymoney/dialogs/kfindtransactiondlg.cpp <span style="color: grey">(7603007)</span></li>
<li>kmymoney/dialogs/kfindtransactiondlgdecl.ui <span style="color: grey">(44fa861)</span></li>
<li>kmymoney/dialogs/kmymoneypricedlgdecl.ui <span style="color: grey">(a484504)</span></li>
<li>kmymoney/dialogs/ksortoptiondlg.ui <span style="color: grey">(e7e28e5)</span></li>
<li>kmymoney/dialogs/ksplitcorrectiondlg.ui <span style="color: grey">(fb6d337)</span></li>
<li>kmymoney/dialogs/ksplittransactiondlgdecl.ui <span style="color: grey">(6b1c706)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127679/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/17/84cb3eaf-fd0d-44c8-80a3-70fe3d6ba2b3__before-kdialog.png">Before KDialog</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/17/eb4e6c79-c0d0-4d9b-8354-8e82f692cb90__after-qdialog.png">After QDialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>