<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127679/">https://git.reviewboard.kde.org/r/127679/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You did not set the branch of this review request, is it master or frameworks?</p></pre>
<br />
<p>- Cristian Oneț</p>
<br />
<p>On April 17th, 2016, 11:14 p.m. UTC, Mitch Frazier wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Mitch Frazier.</div>
<p style="color: grey;"><i>Updated April 17, 2016, 11:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDialog does not work well with Qt Designer.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Changing the widget class from KDialog to QDialog is generally
all that's required. Even though changing from KDialog to
QDialog does remove the OK and Cancel buttons in Designer,
these are added automatically because the dialog class itself
is still KDialog and it by default adds these buttons.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One of the dialogs did require the adding of a setButtons() call
to the constructor to place additional buttons on the dialog
that were previously specified in the .ui file.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Before and after screenshots show what the kfindtransactiondlgdecl.ui
file looks like in Qt Designer before with KDialog and after with QDialog.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note that one of the dialogs, ksplittransactiondlgdecl.ui appears to
be unused and can probably be deleted, although I did not test that.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested the affected dialogs for correct look and function.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/kcurrencycalculatordecl.ui <span style="color: grey">(0bcfd40)</span></li>
<li>kmymoney/dialogs/kcurrencyeditdlgdecl.ui <span style="color: grey">(1527455)</span></li>
<li>kmymoney/dialogs/kfindtransactiondlg.cpp <span style="color: grey">(7603007)</span></li>
<li>kmymoney/dialogs/kfindtransactiondlgdecl.ui <span style="color: grey">(44fa861)</span></li>
<li>kmymoney/dialogs/kmymoneypricedlgdecl.ui <span style="color: grey">(a484504)</span></li>
<li>kmymoney/dialogs/ksortoptiondlg.ui <span style="color: grey">(e7e28e5)</span></li>
<li>kmymoney/dialogs/ksplitcorrectiondlg.ui <span style="color: grey">(fb6d337)</span></li>
<li>kmymoney/dialogs/ksplittransactiondlgdecl.ui <span style="color: grey">(6b1c706)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127679/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/17/84cb3eaf-fd0d-44c8-80a3-70fe3d6ba2b3__before-kdialog.png">Before KDialog</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/04/17/eb4e6c79-c0d0-4d9b-8354-8e82f692cb90__after-qdialog.png">After QDialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>