<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127559/">https://git.reviewboard.kde.org/r/127559/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 7th, 2016, 7:59 p.m. UTC, <b>Christian David</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127559/diff/1/?file=455181#file455181line1967" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/plugins/csvimport/investprocessing.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1967</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">m_shrsinL</span>ist</span> <span class="o">=</span> <span class="n">profilesGroup</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="s">"ShrsinParam"</span><span class="p">,</span> <span class="n">QStringList</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1967</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">l</span>ist</span> <span class="o">=</span> <span class="n">profilesGroup</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="s">"ShrsinParam"</span><span class="p">,</span> <span class="n">QStringList</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should become
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">m_shrsinList = profilesGroup.readEntry("ShrsinParam", m_shrsinList);</code></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The if() is very long and not needed here. However, I still do not know if this is the issue. Also the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">i18nc()s</code> from <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">init()</code> could go here if the readSettings method is always called, which I do not know either.</p></pre>
</blockquote>
<p>On April 8th, 2016, 1:52 p.m. UTC, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should become
m_shrsinList = profilesGroup.readEntry("ShrsinParam", m_shrsinList);</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure I understand this. The second parameter is the default value to return if the key is not found. What does it achieve in this case?</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The if() is very long and not needed here.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There are several ifs around here, but I don't see an unduly long one.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also the i18nc()s from init()
could go here if the readSettings method is always called, which I do not know either.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">readSettings is called only once, from void InvestProcessing::slotFileDialogClicked(), so that code could be moved somewhere in void InvestProcessing::readSettings(), I think.</p></pre>
</blockquote>
<p>On April 8th, 2016, 4:36 p.m. UTC, <b>Łukasz Wojniłowicz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should become
m_shrsinList = profilesGroup.readEntry("ShrsinParam", m_shrsinList);</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I compiled KMyMoney code according to your change for every m_XXXList variable and ran my test case. Proposed line looks neat but doesn't work for me. SellParam= etc. are empty in my csvimporterrc after just created new profile.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">readSettings is called only once, from void InvestProcessing::slotFileDialogClicked(), so that code could be moved somewhere in void InvestProcessing::readSettings(), I think.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please give a code and I'll test it.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I do not know the full conversation but I am pretty sure this patch will not solve the issue. If something in the newly created rc file is missing, the write method seems to fail, not the read method.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My loose observation: Write method is called at the end of importing and read method is called after creating new importing profile for investment.</p></pre>
</blockquote>
<p>On April 8th, 2016, 7:34 p.m. UTC, <b>Christian David</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I do not know the full conversation but I am pretty sure this patch will not solve the issue. If something in the newly created rc file is missing, the write method seems to fail, not the read method.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I withdrew this idea. You should not waste your time with it.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I compiled KMyMoney code according to your change for every m_XXXList variable and ran my test case. Proposed line looks neat but doesn't work for me. SellParam= etc. are empty in my csvimporterrc after just created new profile.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You are right. The code recomended by me has a different behaviour. However, now I doubt that anything I wrote was actually helpfull. I just briefly inspected the code – now I see that is more complex than I thougt. So my recomendations are based on insufficent knowledge. Due to the description in the bug report I still think there is a high chance that the issue is in the write function.</p></pre>
</blockquote>
<p>On April 9th, 2016, 1:01 p.m. UTC, <b>Łukasz Wojniłowicz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Due to the description in the bug report I still think there is a high chance that the issue is in the write function.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And you may be right, look what I've found.
New entry of importing profile in <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$HOME/.kde/share/config/csvimporterrc</code> is created in csvdialog.cpp by following routine</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #B00040">void</span> CSVDialog<span style="color: #666666">::</span>createProfile(QString newName)
{
KSharedConfigPtr config <span style="color: #666666">=</span> KSharedConfig<span style="color: #666666">::</span>openConfig(KStandardDirs<span style="color: #666666">::</span>locateLocal(<span style="color: #BA2121">"config"</span>, <span style="color: #BA2121">"csvimporterrc"</span>));
KConfigGroup <span style="color: #0000FF">bankProfilesGroup</span>(config, <span style="color: #BA2121">"BankProfiles"</span>);
bankProfilesGroup.writeEntry(<span style="color: #BA2121">"BankNames"</span>, m_profileList);
bankProfilesGroup.config()<span style="color: #666666">-></span>sync();
KConfigGroup <span style="color: #0000FF">bankGroup</span>(config, <span style="color: #BA2121">"BankProfiles"</span>);
QString txt <span style="color: #666666">=</span> <span style="color: #BA2121">"Profiles-"</span> <span style="color: #666666">+</span> newName;
KConfigGroup <span style="color: #0000FF">profilesGroup</span>(config, <span style="color: #BA2121">"Profiles-New Profile###"</span>);
KSharedConfigPtr configBackup <span style="color: #666666">=</span> KSharedConfig<span style="color: #666666">::</span>openConfig(KStandardDirs<span style="color: #666666">::</span>locate(<span style="color: #BA2121">"config"</span>, <span style="color: #BA2121">"csvimporterrc"</span>));
KConfigGroup <span style="color: #0000FF">bkprofilesGroup</span>(configBackup, <span style="color: #BA2121">"Profiles-New Profile###"</span>);
KConfigGroup <span style="color: #0000FF">newProfilesGroup</span>(config, txt);
bkprofilesGroup.copyTo(<span style="color: #666666">&</span>newProfilesGroup);
newProfilesGroup.writeEntry(<span style="color: #BA2121">"FileType"</span>, m_fileType);
<span style="color: #008000; font-weight: bold">if</span> (m_fileType <span style="color: #666666">==</span> <span style="color: #BA2121">"Invest"</span>) {
m_investProcessing<span style="color: #666666">-></span>m_shrsinList <span style="color: #666666">=</span> bkprofilesGroup.readEntry(<span style="color: #BA2121">"ShrsinParam"</span>, QStringList());
newProfilesGroup.writeEntry(<span style="color: #BA2121">"ShrsinParam"</span>, m_investProcessing<span style="color: #666666">-></span>m_shrsinList);
m_investProcessing<span style="color: #666666">-></span>m_divXList <span style="color: #666666">=</span> bkprofilesGroup.readEntry(<span style="color: #BA2121">"DivXParam"</span>, QStringList());
newProfilesGroup.writeEntry(<span style="color: #BA2121">"DivXParam"</span>, m_investProcessing<span style="color: #666666">-></span>m_divXList);
m_investProcessing<span style="color: #666666">-></span>m_intIncList <span style="color: #666666">=</span> bkprofilesGroup.readEntry(<span style="color: #BA2121">"IntIncParam"</span>, QStringList());
newProfilesGroup.writeEntry(<span style="color: #BA2121">"IntIncParam"</span>, m_investProcessing<span style="color: #666666">-></span>m_intIncList);
m_investProcessing<span style="color: #666666">-></span>m_brokerageList <span style="color: #666666">=</span> bkprofilesGroup.readEntry(<span style="color: #BA2121">"BrokerageParam"</span>, QStringList());
newProfilesGroup.writeEntry(<span style="color: #BA2121">"BrokerageParam"</span>, m_investProcessing<span style="color: #666666">-></span>m_brokerageList);
m_investProcessing<span style="color: #666666">-></span>m_reinvdivList <span style="color: #666666">=</span> bkprofilesGroup.readEntry(<span style="color: #BA2121">"ReinvdivParam"</span>, QStringList());
newProfilesGroup.writeEntry(<span style="color: #BA2121">"ReinvdivParam"</span>, m_investProcessing<span style="color: #666666">-></span>m_reinvdivList);
m_investProcessing<span style="color: #666666">-></span>m_buyList <span style="color: #666666">=</span> bkprofilesGroup.readEntry(<span style="color: #BA2121">"BuyParam"</span>, QStringList());
newProfilesGroup.writeEntry(<span style="color: #BA2121">"BuyParam"</span>, m_investProcessing<span style="color: #666666">-></span>m_buyList);
m_investProcessing<span style="color: #666666">-></span>m_sellList <span style="color: #666666">=</span> bkprofilesGroup.readEntry(<span style="color: #BA2121">"SellParam"</span>, QStringList());
newProfilesGroup.writeEntry(<span style="color: #BA2121">"SellParam"</span>, m_investProcessing<span style="color: #666666">-></span>m_sellList);
m_investProcessing<span style="color: #666666">-></span>m_removeList <span style="color: #666666">=</span> bkprofilesGroup.readEntry(<span style="color: #BA2121">"RemoveParam"</span>, QStringList());
newProfilesGroup.writeEntry(<span style="color: #BA2121">"RemoveParam"</span>, m_investProcessing<span style="color: #666666">-></span>m_removeList);
}
newProfilesGroup.config()<span style="color: #666666">-></span>sync();
}
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">According to above routine, new entries in
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$HOME/.kde/share/config/csvimporterrc</code>
supposedly should be created from template entry (Profiles-New Profile###) in
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$USR/share/config/csvimporterrc</code> (read-only-file).
Moreover all m_XXXList are defined here also and supposedly shouldn't be empty because template entry isn't empty.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On my system (Fedora 23, KDE Frameworks 5.21.0, Qt 5.5.1) it doesn't work though.
Snippets of code:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KStandardDirs::locateLocal("config", "csvimporterrc")</code>
responsible for locating
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$HOME/.kde/share/config/csvimporterrc</code></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KStandardDirs::locate("config", "csvimporterrc")</code>
responsible for locating
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$USR/share/config/csvimporterrc</code></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">both point to the same file and that is
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$HOME/.kde/share/config/csvimporterrc</code></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Config file
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$HOME/.kde/share/config/csvimporterrc</code>
hasn't got "Profiles-New Profile###" so empty values are defined in m_XXXList and in new entry.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KStandardDirs::locate("config", "csvimporterrc")</code> works correctly on my system? I think, yes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">According to http://api.kde.org <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KStandardDirs::locate</code> is convenience function for <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KGlobal::dirs()->findResource(type, filename)</code> where in our case, type is "config" and filename is "csvimporterrc". That function will</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The filename should be a filename relative to the base dir for resources. So is a way to get the path to csvimporterrc to findResource("config", "csvimporterrc"). KStandardDirs will then look into the subdir config of all elements of all prefixes ($KDEDIRS) for a file csvimporterrc and return the path to the first one it finds (e.g. $HOME/.kde/share/config/csvimporterrc). You can use the program kde4-config to list all resource types.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kde4-config --path config</code> gives me
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$HOME/.kde/share/config/:/etc/kde/:$USR/share/kde-settings/kde-profile/default/share/config/:$USR/share/config/</code></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Notice that <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$HOME/.kde/share/config/</code> is before <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$USR/share/config/</code> so it will be quered first by <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KStandardDirs::locate</code> and according to http://api.kde.org <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KStandardDirs::locate</code> will return full path to the first one file it finds and in case of "csvimporterrc" it always will be <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$HOME/.kde/share/config/csvimporterrc</code></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My thoughts:
1) <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KStandardDirs</code> is deprecated and should be replaced with <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QStandardPaths</code> but I don't think it can be done now since I suppose that KMyMoney is compiled against < Qt 5 now.
2) csvimporterrc in <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$USR/share/config/</code> could have unique name, so <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KStandardDirs</code> won't confuse it with the one in local dir but I don't think it's the best idea because "Profiles-New Profile###" is preset with all English types of operations and that won't work for non-English users
3) I still do believe that my original path is good here, because: it won't harm not to fetch empty values from csvimporterrc into KMyMoney, it's reported to work in non-English environment, it shouldn't break usage in English environment</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What are your opinions?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Allan
You've said that your csvimporterrc is initiated with all required values, oppositely to mine; what is your system configuration (OS, KDE, Qt)?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think that this patch should focus on clening up CSVDialog::createProfile. Here are a few hints:
- use only one <a href="http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKSharedConfig.html#a1e98b058e4f3996a3cc69fa4cb4a440a" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">KSharedConfig::openConfig</a> because that already merges local and global configurations so the template should already be present in that object
- remove unused variables
- maybe rename 'Profiles-New Profile###' into something more suggestive like 'Profiles-NewProfileTemplate' (think about how this change would affect a user updating the application)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">About the patch: I don't see why BuyParam should be read in a different way than ShrsinParam so it looks good to me.</p></pre>
<br />
<p>- Cristian</p>
<br />
<p>On April 3rd, 2016, 4:45 a.m. UTC, Łukasz Wojniłowicz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Wojniłowicz.</div>
<p style="color: grey;"><i>Updated April 3, 2016, 4:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=360129">360129</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixes bug #360129. During creation of new investment statement
template, transaction types are initialized in
investprocessing.cpp, but then are overridden with empty fields
from profile that was just created in csvimporterrc which results
in every non-buy transaction unrecognized during the import.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested using financial statement from bug #360129.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(3879819)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127559/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>