<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120339/">https://git.reviewboard.kde.org/r/120339/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's a really nice and clean patch, should one of our developers commit it, or do you have KDE git accounts?</p></pre>
 <br />









<p>- Cristian OneČ›</p>


<br />
<p>On Aprilie 27th, 2015, 9:02 p.m. UTC, Florent Fourcot wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KMymoney.</div>
<div>By Florent Fourcot.</div>


<p style="color: grey;"><i>Updated Aprilie 27, 2015, 9:02 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Weboob (http://weboob.org) is a library and a collection of applications to extract data from the Web. One of the features is to simplify online banking, on many french banks and several outside of France. About 33 modules are currently available.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This module provides a easy way to import the transactions extracted by Weboob in Kmymoney, providing an online banking like the aqbanking module.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The module needs krosspython to work. It works on both debian stable/debian sid.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All comments of Christian David have been fixed in the V2.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(74e6aaa)</span></li>

 <li>kmymoney/plugins/CMakeLists.txt <span style="color: grey">(1a43470)</span></li>

 <li>kmymoney/plugins/weboob/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/dialogs/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/dialogs/mapaccount.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/dialogs/mapaccount.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/dialogs/mapaccount.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/dialogs/webaccount.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/dialogs/webaccount.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/dialogs/webaccount.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/kmm_weboob.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/kmm_weboob.rc <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/plugin.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/weboob.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/weboob.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/plugins/weboob/weboob.py <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120339/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>