<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122545/">https://git.reviewboard.kde.org/r/122545/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Christian David.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2015, 5:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added the obligatory context menu with "new", "edit" and "remove"
options to a context menu to the outbox for onlineJobs.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This breaks with a KMyMoney design concept where the actions connect to
a slot in KMyMoneyApp. Naturally the edit and remove slots should be in
the onlineJobs view (as that is the place where the edit and remove
takes place). So the action is connected to the view directly.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is this okay for you?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Manual test of new Ui, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">make test</code></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/kmymoney.h <span style="color: grey">(d0011dd2c3dd5fd3efd5c6b3c1be15e2baa6b5c5)</span></li>
<li>kmymoney/kmymoney.cpp <span style="color: grey">(1af957d05e5ed3bb183e1f98a33ee5e964979ccc)</span></li>
<li>kmymoney/kmymoneyui.rc <span style="color: grey">(f2ceb2e731133b5e3680ab3d740ff6393a1e314b)</span></li>
<li>kmymoney/views/kmymoneyview.h <span style="color: grey">(00fcb78dd2c2ae89ccbe793b7a44ae4c401ddf30)</span></li>
<li>kmymoney/views/kmymoneyview.cpp <span style="color: grey">(b103b8bd4b30800e869b64bc526e4e8c1bdc01af)</span></li>
<li>kmymoney/views/konlinejoboutbox.h <span style="color: grey">(6dc52685f30ad7b6deb8f8db95ff7ff2906f6921)</span></li>
<li>kmymoney/views/konlinejoboutbox.cpp <span style="color: grey">(a05821a924d0b4e75864cdd2981859c88284c89a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122545/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>