<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122364/">https://git.reviewboard.kde.org/r/122364/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That is a really huge diff. Here are some things I noticed while skimed through it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It seems you reduced the code; very good!</p></pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line496" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>496</th>
<td><pre><span class="gi">+ <string>Select 'Amount' if only one value column, otherwise select 'Debit/credit'.</string></span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I do not understand this: "…if only one value column…"</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line499" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>499</th>
<td><pre><span class="gi">+ <string extracomment="Select 'Amount' if only one value column, otherwise select "/></span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I do not understand this: "…if only one value column…"</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line907" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>907</th>
<td><pre><span class="gi">+#include <ui_csvwizard.h></span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This should be <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">#include "…"</code></p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line930" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>930</th>
<td><pre><span class="gi">+ m_investProcessing->m_csvDialog = this;</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is more a general annotation:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You are giving the child access to it's parent. This violates the object-oriented principle of modularity. Thus maintaince is harder and the risk of bugs is higher.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line941" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>941</th>
<td><pre><span class="gi">+ QFont font(QApplication::font());</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is this used anywhere?</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line942" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>942</th>
<td><pre><span class="gi">+ QFontMetrics cellFontMetrics(font);</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is this used anywhere?</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line1023" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>1023</th>
<td><pre><span class="gi">+ m_wiz->m_pageCompletion->ui->comboBox_decimalSymbol->setCurrentIndex(-1);</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This should be done in a more modular fashion (general annotation).</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line930" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>1113</th>
<td><pre><span class="gi">+ Qt::WindowFlags eFlags = windowFlags ();</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Qt::WindowFlags eFlags = windowFlags();</code> (space removed)</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line1114" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>1114</th>
<td><pre><span class="gi">+ eFlags |= Qt::WindowStaysOnTopHint;</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This part can be removed, the flag is set and removed again. Also you call show() twice.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line1226" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>1226</th>
<td><pre><span class="gi">+ m_wiz->m_pageBanking->ui->comboBoxBnk_dateCol->setCurrentIndex(-1);</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You are calling setCurrentIndex() later again. So these lines are not needed as their change is overwritten anyway (or do you need the change signal to get emitted?).</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line1286" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>1286</th>
<td><pre><span class="gi">+ m_wiz->m_pageCompletion->ui->comboBox_decimalSymbol->setCurrentIndex(-1); // Ensure UI gets changed.</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why do you need the ui to change?</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line1464" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>1464</th>
<td><pre><span class="gi">+ disconnect(m_wiz->m_pageBanking->ui->comboBoxBnk_amountCol, SIGNAL(currentIndexChanged(int)), m_wiz, SLOT(amountColumnSelected(int)));</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why do you disconnect and reconnect later? Also this connection should be done in CSVWizard.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line1653" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>1653</th>
<td><pre><span class="gi">+ m_tableHeight = m_visibleRows * m_rowHeight + m_header + m_hScrollBarHeight + m_dpiDiff;</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hehe, such annoying calculations appear if you do not trust the library ;)</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line1683" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>1683</th>
<td><pre><span class="gi">+ rect.setHeight(m_tableHeight + 2 *(vLayoutMargin.left() + 1) + 2 + 1);</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">+ 2 + 1</code> ?</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line1495" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>1495</th>
<td><pre><span class="gi">+ m_wiz->m_pageBanking->ui->comboBoxBnk_numberCol->clear(); // clear all existing items before adding new ones</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You have the method <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">clearColumnNumbers()</code> for this already.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line1961" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>1961</th>
<td><pre><span class="gi">+ m_wiz->resetComboBox(type, col); // reset this combobox</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"reset this combobox" - the name <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">resetComboBox()</code> is descriptive already.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I noticed this at several places: You are using a lot of whitespace. This makes it harder for me to read the code.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line2266" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>2266</th>
<td><pre><span class="gi">+ Qt::WindowFlags eFlags = windowFlags ();</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Here <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">show()</code> is called twice and setting the flag has no effect as it is removed again.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line2340" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>2340</th>
<td><pre><span class="gi">+ if ((m_wiz->m_pageIntro->isVisible()) || (m_wiz->m_pageLinesDate->isVisible())) {</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">if (m_wiz->m_pageIntro->isVisible() || m_wiz->m_pageLinesDate->isVisible())</code></p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line2358" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>2358</th>
<td><pre><span class="gi">+ Qt::WindowFlags eFlags = windowFlags ();</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Same as before.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line2438" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>2438</th>
<td><pre><span class="gi">+ disconnect(m_wiz->m_pageSeparator->ui->comboBox_fieldDelimiter, SIGNAL(currentIndexChanged(int)), this, SLOT(delimiterChanged()));</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why is this disconnected? It is connected again later. This may save some of your time: http://qt-project.org/doc/qt-4.8/qt.html#ConnectionType-enum</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line2567" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>2567</th>
<td><pre><span class="gi">+ m_wiz->ui->label_intro->setText("<b>" + str + "</b>");</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">m_wiz->ui->label_intro->setText(QLatin1String("<b>") + str + QLatin1String("</b>"));</code></p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line2504" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>2504</th>
<td><pre><span class="gi">+int CSVDialog::maxColumnCount()</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This method should be <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">const</code>.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line3883" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>3883</th>
<td><pre><span class="gi">+ QList<int> m_memoColList;</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Usually you want member variables to be private.</pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line3891" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>3891</th>
<td><pre><span class="gi">+ QStringList m_columnTypeList; // holds field types - date, payee, etc.</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QStringList m_columnTypeList; // holds field types - date, payee, etc.</code></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">to</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">/** holds field types - date, payee, etc. */
QStringList m_columnTypeList;</code></p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">then doxygen can help you</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line3899" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>3899</th>
<td><pre><span class="gi">+ bool m_amountSelected;</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am not sure here; do these values depend on a user selection? If so it is usualy better to "calculate" them on request. Having a copy quickly leads to inconsistent data.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line4671" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>4671</th>
<td><pre><span class="gi">+#include <QtGui/QWizard></span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Library includes should be above project includes.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line4911" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>4911</th>
<td><pre><span class="gi">+ if (ret == KMessageBox::No) {</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">else if</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line4938" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>4938</th>
<td><pre><span class="gi">+ if (ret == KMessageBox::No) {</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">else if</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line4889" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>4889</th>
<td><pre><span class="gi">+void CSVWizard::creditColumnSelected(int col)</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This method looks very similar to the following <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">…ColumnSelected()</code> methods. They could be compacted with some template magic.</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122364/file/1836/#source/line5030" style="color: black; font-weight: bold; font-size: 9pt;">0002-BUG-340656.patch</a>
<p>Updated patch</p>
<div><table class="sidebyside text-review-ui-table text-review-ui-comment-thumbnail ">
<colgroup>
<col class="line" />
<col class="right" />
</colgroup>
<tbody>
<tr>
<th>5030</th>
<td><pre><span class="gi">+ KMessageBox::information(0, i18n("The '<b>%1</b>' field already has this column selected. <center>Please reselect both entries as necessary.</center>"</span></pre></td>
</tr>
</tbody>
</table>
</div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can this <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;"><center></code> work? There is no new paragraph or line break.</p></pre>
</div>
<br />
<p>- Christian David</p>
<br />
<p>On Februar 3rd, 2015, 1:27 vorm. CET, Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2015, 1:27 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=340656">340656</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix display on high-definition monitors. Fix interaction between the import preview table widget and the parameter entry wizard, caused by them both resizing dynamically within the same window. This was achieved by creating a new class and UI for the wizard and transferring most of the existing relevant code out of the large csvdialog.cpp file into the new class and file. Unfortunately, because 11 UIs are affected and the transfer of existing logic into a new class, the patch is quite large, although there is little new code involved.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on 96 DPI and 160 DPI. Also, the OP of the bug has tested the patch and confirms its performance.
There is one remaining UI not yet included. I've completed its testing, but as it's a little-used window, I've held it back to avoid making this patch even larger.
I'm unable to test on Windows.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/csvwizard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/csvwizard.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/introwizardpage.ui <span style="color: grey">(2bf93f0)</span></li>
<li>kmymoney/plugins/csvimport/investmentdlg.cpp <span style="color: grey">(5e7ce06)</span></li>
<li>kmymoney/plugins/csvimport/investmentwizardpage.ui <span style="color: grey">(d3f2857)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.h <span style="color: grey">(3c08dee)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(2b6b2d1)</span></li>
<li>kmymoney/plugins/csvimport/lines-datewizardpage.ui <span style="color: grey">(01d7253)</span></li>
<li>kmymoney/plugins/csvimport/redefinedlgdecl.ui <span style="color: grey">(26d8b62)</span></li>
<li>kmymoney/plugins/csvimport/separatorwizardpage.ui <span style="color: grey">(21136f2)</span></li>
<li>kmymoney/plugins/csvimport/CMakeLists.txt <span style="color: grey">(36e5afc)</span></li>
<li>kmymoney/plugins/csvimport/bankingwizardpage.ui <span style="color: grey">(9e1b5cb)</span></li>
<li>kmymoney/plugins/csvimport/completionwizardpage.ui <span style="color: grey">(ce61e89)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.h <span style="color: grey">(780329d)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.cpp <span style="color: grey">(b986317)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.ui <span style="color: grey">(166b04a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122364/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/6e4dad98-936c-4ca0-8804-c4abb9b51438__0002-BUG-340656.patch">Updated patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>