<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122150/">https://git.reviewboard.kde.org/r/122150/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On Januar 20th, 2015, 2:23 nachm. CET, <b>Thomas Baumgart</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To me this looks like that uploaded patch is not based on the current master version. Please check that things are in sync, update the patch before we can review it.</p></pre>
 </blockquote>







</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi Shayantan, please dismiss this review request. Thank you!</p></pre>
<br />










<p>- Christian</p>


<br />
<p>On Januar 19th, 2015, 4:42 nachm. CET, Shayantan  Pal wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KMymoney and Christian David.</div>
<div>By Shayantan  Pal.</div>


<p style="color: grey;"><i>Updated Jan. 19, 2015, 4:42 nachm.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Feeds data to an SQLite Database from an excel file</p></pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kmymoney/mymoney/onlinejobtypedtest.cpp <span style="color: grey">(189df04413120050e26ad8199a31d2c68c8f2960)</span></li>

 <li>kmymoney/mymoney/payeeidentifier/payeeidentifierdata.h <span style="color: grey">(a6899c1f018a5b34dcf585e6b61995b6cb107ac0)</span></li>

 <li>kmymoney/mymoney/onlinejobmessage.cpp <span style="color: grey">(3597364a198703f2356801bfddc434bda9d993c1)</span></li>

 <li>kmymoney/mymoney/onlinejobtyped.h <span style="color: grey">(c23599f3b4b9523d11bbc31bb38c390068890572)</span></li>

 <li>kmymoney/models/onlinejobmodel.h <span style="color: grey">(8ff20bd1881d3e4a2605183d392baf92002dea1d)</span></li>

 <li>kmymoney/models/onlinejobmodel.cpp <span style="color: grey">(e369eed334cbd80770e41a15b19222db1079a1b2)</span></li>

 <li>kmymoney/models/payeeidentifiermodel.cpp <span style="color: grey">(9fff26c6b615976ab621911b9b688f75d45d3087)</span></li>

 <li>kmymoney/mymoney/mymoneypayeeidentifiercontainer.h <span style="color: grey">(190604416445ef26056fa021ff08fa8d2bfcb269)</span></li>

 <li>kmymoney/mymoney/mymoneypayeeidentifiercontainer.cpp <span style="color: grey">(c5cc8da3a2905da6157dfa29f10bed29eb86280e)</span></li>

 <li>kmymoney/mymoney/onlinejob.h <span style="color: grey">(8ae40202e88e198189201d5325523b3fc01bd3e2)</span></li>

 <li>kmymoney/mymoney/onlinejobadministration.h <span style="color: grey">(83650a1272be6e1660b18df335c1a5f202dfa990)</span></li>

 <li>kmymoney/mymoney/onlinejobfolder.h <span style="color: grey">(b5a96c070b44849de461cae9cd81f31991fd2aa8)</span></li>

 <li>kmymoney/mymoney/onlinejobfolder.cpp <span style="color: grey">(432fe7d8f938fd9a39057757210d0ee0e6e45294)</span></li>

 <li>kmymoney/mymoney/onlinejobmessage.h <span style="color: grey">(f520c25b69cee4406b9ffe10a377332bb008296d)</span></li>

 <li>kmymoney/misc/charvalidator.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/misc/charvalidator.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kmymoney/CMakeLists.txt <span style="color: grey">(653734a2d410de4070133f8ff6686bd416e1a913)</span></li>

 <li>kmymoney/converter/mymoneystatementreader.cpp <span style="color: grey">(17eba4df32d5142ed16149917245b9529994a4e5)</span></li>

 <li>kmymoney/dialogs/konlinetransferform.cpp <span style="color: grey">(6ab9a2f41a650fe96adc8f15994f7600150136f4)</span></li>

 <li>kmymoney/dialogs/konlinetransferformdecl.ui <span style="color: grey">(7246541fb34db8dcbf9e59a722d272edd509ceb1)</span></li>

 <li>kmymoney/kmymoney.cpp <span style="color: grey">(a3de0df5309b95ad507c501e74cb057c7cdad60a)</span></li>

 <li>kmymoney/kmymoneyutilstest.h <span style="color: grey">(bb75b60e79214e8b7f036c984738d129c4460d0f)</span></li>

 <li>kmymoney/kmymoneyutilstest.cpp <span style="color: grey">(7be55c80874b1779832d619caf4b95c032013780)</span></li>

 <li>kmymoney/misc/CMakeLists.txt <span style="color: grey">(ab29cfac55070a00db5df5a13d27b1ff93dd5867)</span></li>

 <li>kmymoney/mymoney/payeeidentifier/payeeidentifiermacros.h <span style="color: grey">(96251afe1242977473c96514a16f6fce945305cc)</span></li>

 <li>kmymoney/mymoney/payeeidentifier/payeeidentifiertyped.h <span style="color: grey">(07d3abbe61cce60f5bec110038178ec4fbf0d6a7)</span></li>

 <li>kmymoney/mymoney/storage/kmymoney-sqlstorageplugin.desktop <span style="color: grey">(3bd3531221f42a48adedb67db023699b6ee4a328)</span></li>

 <li>kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp <span style="color: grey">(04873dc9568ab63cde637aad8a037a00dbede7e4)</span></li>

 <li>kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp <span style="color: grey">(c6a248967e1ba156534253b3200560ac281b9064)</span></li>

 <li>kmymoney/mymoney/storage/mymoneystoragesql.h <span style="color: grey">(ce65996452769e1beb6982205f9a781b7d0cc6f5)</span></li>

 <li>kmymoney/mymoney/storage/mymoneystoragesql.cpp <span style="color: grey">(a9049cc03cef650b4668f08f4987a65b8f27dcc2)</span></li>

 <li>kmymoney/payeeidentifier/ibanandbic/CMakeLists.txt <span style="color: grey">(71aededa81e222784f7f6a85a9d71df4c1ac8697)</span></li>

 <li>kmymoney/payeeidentifier/ibanandbic/bicmodel.h <span style="color: grey">(8611da4f45f62bc61b7e07ad2368ff22ab605ada)</span></li>

 <li>kmymoney/payeeidentifier/ibanandbic/bicmodel.cpp <span style="color: grey">(2caf8c10bde555f0db46680ace0013687bd06857)</span></li>

 <li>kmymoney/payeeidentifier/ibanandbic/ibanbic.h <span style="color: grey">(399cc05f1b6e33e49062a1936bce070e5df6b1de)</span></li>

 <li>kmymoney/payeeidentifier/ibanandbic/ibanbic.cpp <span style="color: grey">(76c25ca29e2849e68eda0a0c73252f2d37c6125d)</span></li>

 <li>kmymoney/payeeidentifier/ibanandbic/ibanbicdata.h <span style="color: grey">(ccfd8ff62e4fac73ec55a0fa49b5bfadd47d8d9b)</span></li>

 <li>kmymoney/payeeidentifier/ibanandbic/ibanbicdata.cpp <span style="color: grey">(baca85b95393e786e1adb23ec40a312984dd503f)</span></li>

 <li>kmymoney/payeeidentifier/ibanandbic/ibanbicmacros.h <span style="color: grey">(dd48be0b6adabe17209a0fd2b39df32a452bee77)</span></li>

 <li>kmymoney/payeeidentifier/ibanandbic/ibanbicstorageplugin.cpp <span style="color: grey">(7b094ab08667094de8eb85983822fdf91a87a6ad)</span></li>

 <li>kmymoney/payeeidentifier/ibanandbic/tests/internationalaccountidentifiertest.h <span style="color: grey">(568fdec141087593de3aecfcf317c7ac3dd407e0)</span></li>

 <li>kmymoney/payeeidentifier/ibanandbic/widgets/ibanbicitemdelegate.h <span style="color: grey">(2cd3dd8ca69bdababd49b625197c34d03eeac06a)</span></li>

 <li>kmymoney/payeeidentifier/nationalaccount/CMakeLists.txt <span style="color: grey">(10795ec57a81310b098050f46280e5a74fd92afc)</span></li>

 <li>kmymoney/payeeidentifier/nationalaccount/nationalaccount.h <span style="color: grey">(c16694b367b034d8a2dec55b2c65005d1f3d2c9e)</span></li>

 <li>kmymoney/payeeidentifier/nationalaccount/nationalaccountidmacros.h <span style="color: grey">(12953b9002e68d8be08950dccf975c617560a472)</span></li>

 <li>kmymoney/payeeidentifier/nationalaccount/ui/nationaaccountedit.ui <span style="color: grey">(5acbe8733cbf51d58d65a0857f9542855b7e1a98)</span></li>

 <li>kmymoney/payeeidentifier/unavailableplugin/unavailableplugin.h <span style="color: grey">(5d75832812df9d23d50fdc2c0f5a292f516ec8ab)</span></li>

 <li>kmymoney/payeeidentifier/unavailableplugin/unavailableplugin.cpp <span style="color: grey">(dd6d534f9c73f7d88158ae74cc2ef7b662c646c5)</span></li>

 <li>kmymoney/plugins/csvexport/kmm_csvexport.desktop <span style="color: grey">(3d27b6ca988bfebc824380125f8418100d385892)</span></li>

 <li>kmymoney/plugins/csvimport/csvdialog.h <span style="color: grey">(780329dc00ab7bd05827ce8d50f734183f2738c4)</span></li>

 <li>kmymoney/plugins/csvimport/csvdialog.cpp <span style="color: grey">(b9863179b8abb9e90d3259b5e4e322202cc3f83f)</span></li>

 <li>kmymoney/plugins/csvimport/csvdialog.ui <span style="color: grey">(166b04a27a5c03f1f7dbe0983e9a3fd784fdad2f)</span></li>

 <li>kmymoney/plugins/csvimport/kmm_csvimport.desktop <span style="color: grey">(916e22892c53c8984e3ade5ce891caf40fdf2d9c)</span></li>

 <li>kmymoney/plugins/icalendarexport/kcm_kmm_icalendarexport.desktop <span style="color: grey">(3e249d16e8bb231faaa8a7ff7f6a38f63b7c11bb)</span></li>

 <li>kmymoney/plugins/kbanking/aqbankingkmmoperators.h <span style="color: grey">(3a3f3a23de4c66c5650b732c1ebd6ae5ff6ba019)</span></li>

 <li>kmymoney/plugins/kbanking/aqbankingkmmoperators.cpp <span style="color: grey">(5a99ad816bc9372af9eed201514fee5320638ff2)</span></li>

 <li>kmymoney/plugins/kbanking/gwenhywfarqtoperators.h <span style="color: grey">(0446e6ca40c8577b6c76be927cf3b99dcf4ec10e)</span></li>

 <li>kmymoney/plugins/kbanking/gwenhywfarqtoperators.cpp <span style="color: grey">(0a59e711fee313ac5f2f5dd4440ecac6d19af64e)</span></li>

 <li>kmymoney/plugins/kbanking/gwenkdegui.h <span style="color: grey">(962bf5f7d29f97f3a342009cb6a26365958e92b5)</span></li>

 <li>kmymoney/plugins/kbanking/gwenkdegui.cpp <span style="color: grey">(bed761d54a4d49c379c6899ba41535246bb4086f)</span></li>

 <li>kmymoney/plugins/kbanking/kmm_kbanking.desktop <span style="color: grey">(de63ef584c1c0c25a126d2339e1aac808a0ada52)</span></li>

 <li>kmymoney/plugins/kbanking/mymoneybanking.cpp <span style="color: grey">(211d4622d424f3e58f1fe4469da944c02cab22f2)</span></li>

 <li>kmymoney/plugins/kbanking/qml/chipTan/ChipTanFlickerField.qml <span style="color: grey">(8ca84a7820155123416619e0e89d5844b8c88bf0)</span></li>

 <li>kmymoney/plugins/kmymoney-onlinetaskui.desktop <span style="color: grey">(7d88755456b70b5c130c5b8e066638b213ad556d)</span></li>

 <li>kmymoney/plugins/kmymoney-payeeidentifierdelegate.desktop <span style="color: grey">(895e97c52e840c7226d4b0e4f8c052cf0390cd1d)</span></li>

 <li>kmymoney/plugins/ofximport/kmm_ofximport.desktop <span style="color: grey">(0c43d24ce27dd2d6c66d9cbaa42a4a0b46f831b8)</span></li>

 <li>kmymoney/plugins/onlinejobpluginmockup/germancredittransfersettingsmockup.h <span style="color: grey">(a68f8a8c9e4d02771a02522b4408f29c05776d13)</span></li>

 <li>kmymoney/plugins/onlinejobpluginmockup/kmm_onlinejobpluginmockup.desktop <span style="color: grey">(fbb14a7891d7a887f4d6a415186ee4ddcbe5d631)</span></li>

 <li>kmymoney/plugins/onlinejobpluginmockup/onlinejobpluginmockup.cpp <span style="color: grey">(dd533d37e19dacf67f58ceb9f6f0a1d4e99b4aaf)</span></li>

 <li>kmymoney/plugins/onlinetasks/dummy/tasks/dummytask.h <span style="color: grey">(d8f2d82b15d3af092b94e2f5f95192850b097125)</span></li>

 <li>kmymoney/plugins/onlinetasks/interfaces/converter/onlinetaskconverter.h <span style="color: grey">(87fd4cfdfb0041ff64aa27344917c9ac449edf16)</span></li>

 <li>kmymoney/plugins/onlinetasks/interfaces/tasks/credittransfer.h <span style="color: grey">(7ed73744419187beeaacaa7fb2bfb588c3813182)</span></li>

 <li>kmymoney/plugins/onlinetasks/interfaces/tasks/onlinetask.h <span style="color: grey">(266b9246cb368e10c2b8fef6c0289d90dce90305)</span></li>

 <li>kmymoney/plugins/onlinetasks/national/CMakeLists.txt <span style="color: grey">(18585001e8332d72b5016df66154206b3804d1e4)</span></li>

 <li>kmymoney/plugins/onlinetasks/national/nationalonlinetasksloader.cpp <span style="color: grey">(f8c68db0a14fd7d4dcce3504d227ee57b5f0fb9e)</span></li>

 <li>kmymoney/plugins/onlinetasks/national/nationalstorageplugin.cpp <span style="color: grey">(3899d3a88878f15873b3ab3d9d87bbab2f199fd9)</span></li>

 <li>kmymoney/plugins/onlinetasks/national/tasks/germanonlinetransferimpl.cpp <span style="color: grey">(cc1871048b5b6b3c1fc7c5a22a6227742a570ef1)</span></li>

 <li>kmymoney/plugins/onlinetasks/national/tests/CMakeLists.txt <span style="color: grey">(0a3a4f498917ac3676c37fbc903c668323bb43b9)</span></li>

 <li>kmymoney/plugins/onlinetasks/national/ui/germancredittransferedit.cpp <span style="color: grey">(9a87313ff02762e6ddad652bb095b3f6519899ea)</span></li>

 <li>kmymoney/plugins/onlinetasks/national/ui/germancredittransferedit.ui <span style="color: grey">(919a6d672adba3142e61cac8851642ada7f7fde0)</span></li>

 <li>kmymoney/plugins/onlinetasks/sepa/sepaonlinetasksloader.cpp <span style="color: grey">(91bbb6b553980c0d7bece371032f1e36e825a422)</span></li>

 <li>kmymoney/plugins/onlinetasks/sepa/sepastorageplugin.cpp <span style="color: grey">(18165552b87520520c57086603480c68a73a00d8)</span></li>

 <li>kmymoney/plugins/onlinetasks/sepa/tasks/sepaonlinetransferimpl.cpp <span style="color: grey">(3012b40b6549cad943ef0877c9c1d914f46aaa64)</span></li>

 <li>kmymoney/plugins/onlinetasks/sepa/ui/sepacredittransferedit.cpp <span style="color: grey">(98a6be2a7ee1ace8d95191c31ac7eec1bb53ed05)</span></li>

 <li>kmymoney/plugins/onlinetasks/sepa/ui/sepacredittransferedit.ui <span style="color: grey">(22ae0c6d23d5486cc2ebe243e4f351d7d32e3dbb)</span></li>

 <li>kmymoney/plugins/onlinetasks/unavailabletask/tasks/unavailabletask.h <span style="color: grey">(6650ba5b03380d05255bf3bd880c1a2ee5b6ca97)</span></li>

 <li>kmymoney/plugins/onlinetasks/unavailabletask/tasks/unavailabletask.cpp <span style="color: grey">(d5e064066fd6e5c5cbcc8a2e6dccc6e9839f13cf)</span></li>

 <li>kmymoney/plugins/printcheck/kcm_kmm_printcheck.desktop <span style="color: grey">(a42ad50240c01f5d1765de5f31da0382ac53e62e)</span></li>

 <li>kmymoney/plugins/printcheck/kmm_printcheck.desktop <span style="color: grey">(8217f14f3151ca6f121bd651bbecc02393487372)</span></li>

 <li>kmymoney/plugins/sqlcipher/qsqlcipherdriverplugin.cpp <span style="color: grey">(886993fea3aa3c274746f8d1ee614c62b540d705)</span></li>

 <li>kmymoney/views/khomeview.cpp <span style="color: grey">(2cbe6cdb1feb935e9384ba80ee6b927cee869464)</span></li>

 <li>kmymoney/views/kmymoneyview.cpp <span style="color: grey">(52843f4fccb9cbd329c69617e228d6f6af056f54)</span></li>

 <li>kmymoney/views/konlinejoboutbox.h <span style="color: grey">(df60466e0dfc52fada65aec701a9ac5235383108)</span></li>

 <li>kmymoney/views/konlinejoboutbox.cpp <span style="color: grey">(bb43e890360ba0d17e422f4fcfdf228e515a9d98)</span></li>

 <li>kmymoney/views/konlinejoboutbox.ui <span style="color: grey">(8a6f37d094844e41b10dedf65851fe363333c9a1)</span></li>

 <li>kmymoney/views/kreportsview.cpp <span style="color: grey">(c02e89f6b4b59f6c26994821824a87ad7e1a4082)</span></li>

 <li>kmymoney/views/payeeidentifierselectiondelegate.h <span style="color: grey">(655df4c21afe6a976314b423d51791aba7ee2386)</span></li>

 <li>kmymoney/views/payeeidentifierselectiondelegate.cpp <span style="color: grey">(b6dd586b470e47d5eeff6485931bd996d6594bff)</span></li>

 <li>kmymoney/widgets/CMakeLists.txt <span style="color: grey">(36c7b86ccb35f614d9c891418ddf4b34e88ae13e)</span></li>

 <li>kmymoney/widgets/fixedcolumntreeview.h <span style="color: grey">(3ef39c9f18a90f7cba13b3239d751411366ef745)</span></li>

 <li>kmymoney/widgets/kmymoney_export.h <span style="color: grey">(a3d4562af0ffea8c38d8b725a42aec16cc3214b0)</span></li>

 <li>kmymoney/widgets/kmymoneymvccombo.cpp <span style="color: grey">(41ae18857f9451eca56a172aafa0b8e2d53177f2)</span></li>

 <li>kmymoney/widgets/kmymoneytextedit_p.h <span style="color: grey">(bb8a20fa2f6e2088d8f210307e921c70417cf88c)</span></li>

 <li>kmymoney/widgets/kmymoneyvalidationfeedback.ui <span style="color: grey">(b5ff21ee5131965d7260be02df882f7cbc256c4a)</span></li>

 <li>tools/CMakeLists.txt <span style="color: grey">(169c5d80c325d05322e7467b33e01314a264c3c8)</span></li>

 <li>tools/xea2kmt.cpp <span style="color: grey">(a5bc5699c07289f0631cf8a2708ca014847f93f5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122150/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>