<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120153/">https://git.reviewboard.kde.org/r/120153/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've been drawn back to this because of another bug I'm looking at -
"[Bug 322381] Fees(taxes) are deducted twice from dividend amount after QIF import".
As mymoneystatementreader.cpp is involve also in QIF and CSV importing, I suspect
there may be a side effect of this change.
In mymoneyqifreader.cpp, I see the following -</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"// For historic reasons (coming from the OFX importer) the statement reader
// expects the dividend with a reverse sign. So we just do that.
tr.m_amount = -(amount - tr.m_fees);"</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Will not a corresponding change be required here? I suspect this may be in part
contributing to Bug 322381. I've removed the -ve sign and it does partially
correct this problem, but I need to look deeper because I suspect there is an
earlier bug too.</p></pre>
<br />
<p>- Allan Anderson</p>
<br />
<p>On September 21st, 2014, 9:33 a.m. UTC, Cristian Oneț wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney and Allan Anderson.</div>
<div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2014, 9:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333522">333522</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As the author of the hack states he's not sure why this was necessary.
This hack also caused a lot of workarounds in MyMoneyStatementReader
so it definitely should be removed. I've tried to keep the current
behaviour in MyMoneyStatementReader but since I'm not familiar with
investment transaction these should be double checked.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: 333522</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Imported the OFX file attached to BUG 333522 in a checking account and in an investemnt account. Allan please take a look if the investment transactions part in MyMoneyStatementReader is OK.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/converter/mymoneystatementreader.cpp <span style="color: grey">(766d2151e17f07891f43e6d4d50861d40cbffe17)</span></li>
<li>kmymoney/plugins/ofximport/ofximporterplugin.cpp <span style="color: grey">(556cb4195ef1c5680ac50ce394f8bd9893fdcbdb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120153/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>