<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120818/">https://git.reviewboard.kde.org/r/120818/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Thomas Baumgart</p>
<br />
<p>On Oktober 26th, 2014, 9:58 nachm. CET, Cristian Oneț wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated Okt. 26, 2014, 9:58 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since the values 1 and -1 seem to be used pretty often (in loops) it's worth to have static values for these constants to benefit from implicit sharing in the places where these values are necessary.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The sharing of value 0 is already provided by AlkValue so we don't need a static value for 0.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch will work just fine with alkimia 4.3.2 but the advantages will be visible when combined with REVIEW 120815.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ran KMyMoney and the tests.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/reports/pivotgrid.cpp <span style="color: grey">(b608a28257ba60c4ec83eb744e1891f58c6dac58)</span></li>
<li>kmymoney/reports/pivotgridtest.cpp <span style="color: grey">(e0deaf07b2fadcbc54dabe96633adde653bbda4f)</span></li>
<li>kmymoney/reports/pivottable.cpp <span style="color: grey">(340f7a8d6ec98bcc2968bec12ecb9706b6cbfff0)</span></li>
<li>kmymoney/reports/querytable.cpp <span style="color: grey">(cd4371946974c8936c076dd4865c763ce6f77edb)</span></li>
<li>kmymoney/reports/reportaccount.cpp <span style="color: grey">(d3b42c33ef09b31545639092676dc76c5d737b65)</span></li>
<li>kmymoney/views/kforecastview.cpp <span style="color: grey">(e5120b03aa345929d92d7af508f16ee54a7e8309)</span></li>
<li>kmymoney/views/kgloballedgerview.cpp <span style="color: grey">(22f40e139fc1d5d9280c84539bdcf9ad457f7de1)</span></li>
<li>kmymoney/views/khomeview.cpp <span style="color: grey">(5f3c66608564edcc6a078dbda9d78122b166c646)</span></li>
<li>kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp <span style="color: grey">(56e7d4112fc4b6b95b11d9de58b47689e5e2e643)</span></li>
<li>kmymoney/wizards/newinvestmentwizard/knewinvestmentwizard.cpp <span style="color: grey">(801b76147b35af7548357ef200a84a8714947374)</span></li>
<li>kmymoney/wizards/newinvestmentwizard/konlineupdatewizardpage.cpp <span style="color: grey">(847ff8c89055774513231c3bb65d1d4155b8407b)</span></li>
<li>kmymoney/wizards/newloanwizard/knewloanwizard.cpp <span style="color: grey">(99ea10fc2ace66f1590d53a7555b39818fc054b3)</span></li>
<li>kmymoney/dialogs/investactivities.cpp <span style="color: grey">(ca425f99d70169d7ba6c80870ab6be86e8069970)</span></li>
<li>kmymoney/dialogs/investtransactioneditor.cpp <span style="color: grey">(4f870039d2de55d73550c944c7f5e3403eb9abd0)</span></li>
<li>kmymoney/dialogs/kcurrencycalculator.cpp <span style="color: grey">(b50aa8a1c6db0fd569adc97cf01877c76465d52f)</span></li>
<li>kmymoney/dialogs/kmymoneypricedlg.cpp <span style="color: grey">(9aa220fb4a558ef0945bb68be85c39b927451e8c)</span></li>
<li>kmymoney/dialogs/knewaccountdlg.cpp <span style="color: grey">(47c20a2708cd998b4b53ee2d97d5dcc1e6bd6021)</span></li>
<li>kmymoney/kmymoney.cpp <span style="color: grey">(84bd9a3a6da487ba0d41bcca48dc82b4842f1c28)</span></li>
<li>kmymoney/models/accountsmodel.cpp <span style="color: grey">(37384d26e7bd7321ddf247b35517da28d4e11a45)</span></li>
<li>kmymoney/mymoney/mymoneyaccounttest.cpp <span style="color: grey">(2506f8eb4efb0053e3e1c7c7ce755b27d288345d)</span></li>
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(dd4af2e3a9883998f2ad95ccecb5bcbfa23068db)</span></li>
<li>kmymoney/mymoney/mymoneyfiletest.cpp <span style="color: grey">(1e196ad92f3890e2e6ecfbcc9da66dad91e6dcf7)</span></li>
<li>kmymoney/mymoney/mymoneyforecast.cpp <span style="color: grey">(9f3e384584f4ded4f72be830fa2dd1f0b18017fd)</span></li>
<li>kmymoney/mymoney/mymoneyforecasttest.cpp <span style="color: grey">(dc098af51620d858728ed706e189d9218ef49543)</span></li>
<li>kmymoney/mymoney/mymoneymoney.h <span style="color: grey">(033983b4fe4c2c140cbeb7b55cdaf9d18c4db154)</span></li>
<li>kmymoney/mymoney/mymoneymoney.cpp <span style="color: grey">(5de7fa9085552c7fae01b7380258ea3752672c52)</span></li>
<li>kmymoney/mymoney/mymoneyprice.cpp <span style="color: grey">(27b847480b3800d512d81dba66639f224c220dfd)</span></li>
<li>kmymoney/mymoney/mymoneypricetest.cpp <span style="color: grey">(1acd388a8928a8d9fcd3e04afd694836c7bb7b2e)</span></li>
<li>kmymoney/mymoney/mymoneysplit.cpp <span style="color: grey">(2f811328a10e4e612d4431c81b467f9e69a57c3b)</span></li>
<li>kmymoney/mymoney/mymoneytransactionfilter.cpp <span style="color: grey">(1883971dcf5fb1ea771efb178b58a30a1698ad65)</span></li>
<li>kmymoney/mymoney/storage/mymoneystorageanon.cpp <span style="color: grey">(08f42f2b8c6cd89fcbb9b449a46bc8406e30746b)</span></li>
<li>kmymoney/reports/objectinfotable.cpp <span style="color: grey">(49d3ae1ed98f374f82c5ed6832a00c12b48a132a)</span></li>
<li>kmymoney/reports/pivotgrid.h <span style="color: grey">(8205eb22ca40e01b66310e33b035aac70b63b675)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120818/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>