<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119207/">https://git.reviewboard.kde.org/r/119207/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated Oct. 18, 2014, 9:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed the race condition by attaching the fetched email to the Akonadi job as a property.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Refactor the contact fetching code into a single class.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This avoids code duplication and makes it easier to transform
the kdepimlibs dependency into an optional one. If kdepimlibs
is not detected the user will not be able to load contact data
from the address book (big deal...).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It also makes it easier to fetch contact data from other parts of the
code, like for a payee.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure about putting this into the kmm_mymoney library but since
it only contains a data source and we don't have another lib for these
kind of objects it ended up here.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">REVIEW: 119207</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested the "Load from addressbook" feature, it works. Also compiled the module without finding the kdepimlibs module, it worked.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(dd3191d80f969b11c596c02dc101065cc4aaf3d7)</span></li>
<li>config-kmymoney.h.cmake <span style="color: grey">(5f3845a46413259d60302ba1b921a266ee3bb1f9)</span></li>
<li>kmymoney/dialogs/knewfiledlg.h <span style="color: grey">(92004714c8bedf8b1cf15bfc1e0f20edcab3a66c)</span></li>
<li>kmymoney/dialogs/knewfiledlg.cpp <span style="color: grey">(b7233a181f8368734a75fbeaa976220f1fad319c)</span></li>
<li>kmymoney/mymoney/CMakeLists.txt <span style="color: grey">(38b3f44dc79250e0a45f031a691a042d49daa550)</span></li>
<li>kmymoney/mymoney/mymoneycontact.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/mymoney/mymoneycontact.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/wizards/newuserwizard/knewuserwizard.cpp <span style="color: grey">(7fd250cfc46db505dd8a1b595a2179c91e0183d9)</span></li>
<li>kmymoney/wizards/newuserwizard/knewuserwizard_p.h <span style="color: grey">(adb4ca564cdd4b70e8cb4c4f1d053c0bd6335c38)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119207/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>