<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120339/">https://git.reviewboard.kde.org/r/120339/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120339/diff/2/?file=316897#file316897line13" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/plugins/weboob/weboob.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">action</span><span class="o">-></span><span class="n">setFile</span><span class="p">(</span><span class="n">path</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It would be nice if scipt errors like "Woboob not installed" could be handled here and somehow would end up in the UI.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've just tested this without Weboob installed and Kross::ErrorInterface returns an interpretor error.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This extreme case could be handled by cmake (detecting Woboob availability) but other python errors should be handled.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Anyway this is a "would be nice to have feature" so I won't open an issue for it.</p></pre>
</div>
</div>
<br />
<p>- Cristian Oneț</p>
<br />
<p>On Octombrie 7th, 2014, 4:06 p.m. UTC, Florent Fourcot wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Florent Fourcot.</div>
<p style="color: grey;"><i>Updated Oct. 7, 2014, 4:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Weboob (http://weboob.org) is a library and a collection of applications to extract data from the Web. One of the features is to simplify online banking, on many french banks and several outside of France. About 33 modules are currently available.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This module provides a easy way to import the transactions extracted by Weboob in Kmymoney, providing an online banking like the aqbanking module.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The module needs krosspython to work. It works on both debian stable/debian sid.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All comments of Christian David have been fixed in the V2.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/weboob/weboob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/weboob/weboob.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(dd3191d)</span></li>
<li>kmymoney/plugins/CMakeLists.txt <span style="color: grey">(eb3a62f)</span></li>
<li>kmymoney/plugins/weboob/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/weboob/dialogs/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/weboob/dialogs/mapaccount.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/weboob/dialogs/mapaccount.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/weboob/dialogs/mapaccount.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/weboob/dialogs/webaccount.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/weboob/dialogs/webaccount.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/weboob/dialogs/webaccount.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/weboob/kmm_weboob.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/weboob/kmm_weboob.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/weboob/plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/weboob/plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/weboob/weboob.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120339/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>