<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120260/">https://git.reviewboard.kde.org/r/120260/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've been working for a while on improving the appearance and operation of the CSV importer plugin, which has gone far more slowly than I expected.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
In the meantime, a new version of KMyMoney has been released for Windows, and two users have reported the known problem of buttons at the foot of the plugin page not appearing fully. Plus, a difficulty with the start page radio buttons. So, there is more urgency now, and I've extracted the reworked UI files, and made a patch which includes them, with a needed small change to the code handling the UI. Also, there is a small fix for occasional crashes related to decimal symbol handling. This is based on the current HEAD. Otherwise, the UI looks much like the HEAD version, apart from the correct visibility of the buttons.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I am still working on improving other parts of the plugin</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've tested the patch on Linux Mint and Ubuntu, with a large number of different files.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I am not able to test on Windows, having only XP.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I don't know if these changes help with the radio button issue on Windows, as I am not able to reproduce the problem here, the radio, and all other, buttons work as expected.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/separatorwizardpage.ui <span style="color: grey">(30b2dc7)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.cpp <span style="color: grey">(7e0229b)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.ui <span style="color: grey">(36e7fd5)</span></li>
<li>kmymoney/plugins/csvimport/csvutil.h <span style="color: grey">(546bfa5)</span></li>
<li>kmymoney/plugins/csvimport/csvutil.cpp <span style="color: grey">(4c0dd25)</span></li>
<li>kmymoney/plugins/csvimport/introwizardpage.ui <span style="color: grey">(9bd29f5)</span></li>
<li>kmymoney/plugins/csvimport/investmentwizardpage.ui <span style="color: grey">(3744963)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.h <span style="color: grey">(55dd4ca)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(c21c679)</span></li>
<li>kmymoney/plugins/csvimport/lines-datewizardpage.ui <span style="color: grey">(fb10a0e)</span></li>
<li>kmymoney/plugins/csvimport/bankingwizardpage.ui <span style="color: grey">(d2179bf)</span></li>
<li>kmymoney/plugins/csvimport/completionwizardpage.ui <span style="color: grey">(99db075)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.h <span style="color: grey">(b9d4527)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120260/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>