<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119207/">https://git.reviewboard.kde.org/r/119207/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Isn't there a race condition when the PIM libs are present and one starts a second search before the first one ended on the same object? Should we prevent that?</p></pre>
<br />
<p>- Thomas Baumgart</p>
<br />
<p>On July 11th, 2014, 8:28 p.m. CEST, Cristian Oneț wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated July 11, 2014, 8:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Refactor the contact fetching code into a single class.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This avoids code duplication and makes it easier to transform<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
the kdepimlibs dependency into an optional one. If kdepimlibs<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
is not detected the user will not be able to load contact data<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
from the address book (big deal...).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It also makes it easier to fetch contact data from other parts of the<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
code, like for a payee.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure about putting this into the kmm_mymoney library but since<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
it only contains a data source and we don't have another lib for these<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
kind of objects it ended up here.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">REVIEW: 119207</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested the "Load from addressbook" feature, it works. Also compiled the module without finding the kdepimlibs module, it worked.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/knewfiledlg.cpp <span style="color: grey">(5b6e8e960184235e3f6bc61439432ea48855a4f4)</span></li>
<li>kmymoney/mymoney/CMakeLists.txt <span style="color: grey">(62f29e88017fae38b1da8f2a18cb35c5b627b573)</span></li>
<li>kmymoney/mymoney/mymoneycontact.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/mymoney/mymoneycontact.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(dacdf606a9320c1926c4d848d0917708f8cdd44f)</span></li>
<li>config-kmymoney.h.cmake <span style="color: grey">(5f3845a46413259d60302ba1b921a266ee3bb1f9)</span></li>
<li>kmymoney/dialogs/knewfiledlg.h <span style="color: grey">(92004714c8bedf8b1cf15bfc1e0f20edcab3a66c)</span></li>
<li>kmymoney/wizards/newuserwizard/knewuserwizard.cpp <span style="color: grey">(7fd250cfc46db505dd8a1b595a2179c91e0183d9)</span></li>
<li>kmymoney/wizards/newuserwizard/knewuserwizard_p.h <span style="color: grey">(adb4ca564cdd4b70e8cb4c4f1d053c0bd6335c38)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119207/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>