<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119635/">https://git.reviewboard.kde.org/r/119635/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Cristian Oneț</p>
<br />
<p>On August 6th, 2014, 1:41 p.m. UTC, Christian David wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Christian David.</div>
<p style="color: grey;"><i>Updated Aug. 6, 2014, 1:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Replaced<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
void KMyMoneyGlobalSettings::setSubstringSearch(QWidget<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> w)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
by void KMyMoneyMVCCombo::setSubstringSearchForChildren(QWidget</em>const widget, bool enabled)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To use this commit you must replace<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
KMyMoneyGlobalSettings::setSubstringSearch(widgetPtr);<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
by<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
KMyMoneyMVCCombo::setSubstringSearchForChildren(widgetPtr, !KMyMoneySettings::stringMatchFromStart());</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So KMyMoneyMVCCombo is not needed in KMyMoneyGlobalSettings anymore and<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
the target kmm_config can be used without linking the target "widgets".</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My goal is to clean up the build of all widgets. Later there should be<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
1) a shared library which contains all KMyMoney widgets which are interessting for plugins,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
2) a static library which contains widgets which are not interessting for plugins (if there are such widgets, at the moment nearly everything is put here)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
3)?a shared library for QtDesigner (which is not working at the moment)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">kwriteconfig --file kmymoneyrc --group "General Options" --key "stringMatchFromStart" --type bool true</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">restarted KMyMoney</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">tried completion for payees in register<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
-- worked as expected --</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">removed option again</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">restarted KMyMoney</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">tried completion for payees in register<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
-- worked as expected --</li>
</ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/kmymoney.cpp <span style="color: grey">(c4bbf0cbf46250f69f7e2e9c13471c4e6c7cb261)</span></li>
<li>kmymoney/kmymoney.kcfg <span style="color: grey">(5d5e09cf9b1d94cec07fe97cda388819fd8a97ed)</span></li>
<li>kmymoney/kmymoneyglobalsettings.cpp <span style="color: grey">(a6742fa9e329579fd81548b20bfda766ebb27863)</span></li>
<li>kmymoney/widgets/kmymoneymvccombo.h <span style="color: grey">(a9d8e37ee0a600240c7ca4544964a448770d0a24)</span></li>
<li>kmymoney/widgets/kmymoneymvccombo.cpp <span style="color: grey">(cf7c21b25716aa99d9e72ee19883f371da816c0c)</span></li>
<li>kmymoney/wizards/endingbalancedlg/kendingbalancedlg.cpp <span style="color: grey">(adb2adae4c8e086df0a1ce5e62a36cb26859dc76)</span></li>
<li>kmymoney/wizards/newloanwizard/knewloanwizard.cpp <span style="color: grey">(5b8134e1345a863a13469dfd32eb56ed99b9bdc2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119635/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>