<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117620/">https://git.reviewboard.kde.org/r/117620/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 18th, 2014, 1:34 p.m. CEST, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Cristian
Many thanks. It had been starting to dawn on me that, when dealing with different distros, it shouldn't be necessary to fiddle about with margins
to get things to look right. I'd suspected that I needed to make some fundamental changes, but wasn't really ready to take the plunge. Anyway,
you've done it for me, so again, thank you.
The question now is, where do we go from here?
Here, I'd already removed a chunk of code and have been working on details of the UI appearance. For instance, I don't like to see the size of the
table changing height between the different wizard pages, and I don't like to see just partial lines displayed. Obviously, if the user decides to do
a resize, then the decision is his, but without that happening, I don't want to see half lines displayed. This is mainly to do with whether a
horizontal scroll-bar is visible or not. I have not been able to get that to work correctly. Sometimes, it is visible but isVisible() returns
false, and vice versa I think. So I've had to calculate the diplayed width and adjust the containing rectangle. A little work is still needed here.
In your pruning, I think you have removed some vertical spacers, which is causing the combo-boxes to shift upwards, leaving a lot of space below.
I wish to revert that. In the separators wizard page, the two combo-boxes are now different sizes, I think because you've removed the form layout I was
using. In the banking wizard, the combo-box sizes are significantly different in width between Linux Mint and Ubuntu. I don't know about on Windows.
These are very minor points, but I'd like to tweak them.
I'd decided on a default window height of 10 rows, which has been changed. Was there a particular reason for that?
Between Mint and Ubuntu, the margin values are still different, but now that has no effect on the appearance. The font sizes are differ too, 9 point
against 11 point. That does affect the appearance. Should I leave that as is, do you think? I think probably yes.
I can't add a revised patch to your review, but if you agree, I can describe any proposed changes. I don't want to stray away from your major changes,
though, obviously.</pre>
</blockquote>
<p>On April 18th, 2014, 2:19 p.m. CEST, <b>Cristian Oneț</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"where do we go from here?"
I don't know, it's up to you to decide. If you ask me (after 2 days of going trough csvdialog.cpp) I would suggest to rewrite everything. I know that seems harsh but frankly I didn't see such "tangled up" code in a while. One reading it couldn't quite tell what is essential (necessary) in there and what is trial/error leftover code.
For the UI I would have the following guide:
- keep it simple (your layouts were really, really complicated)
- don't center everything (including messages)
- don't set fix sizes (fixed size policies are OK in the appropriate place - line edits, combos should have a fixed vertical size hint)
- try to use the available space as uniformly as possible (1 page with 2 combos vs. 1 page with 10 combos)
- now we have a dialog (QWizard) inside another dialog (CSVDialog - former widget) which seems a bad idea to me
For the code:
- don't keep everything together (like a big ball of spaghetti), try to break it up into smaller components
- only keep the essential code otherwise you won't be able to spot it later from the clutter
Until the csv importer plugin will not be cleaned up, clean reviewable patches can't be provided because the patches will always look like the code that is patched.</pre>
</blockquote>
<p>On April 18th, 2014, 2:21 p.m. CEST, <b>Cristian Oneț</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Forgot to mention the fonts: don't set any fonts - let the user choose the fonts he desires using the system settings.</pre>
</blockquote>
<p>On April 18th, 2014, 2:41 p.m. CEST, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've never made any claim to be a programmer! This all started off as a script to produce a QIF file, which I was advised to expand, first into
tabs, and later into a wizard. It has grown, like Topsy. I've learned a lot along the way, but I'm still not a programmer.
In the light of your comments, there seems little point now wasting time tuning what we have, so I'll leave it as is.
When/if a rewrite occurs will depend upon my available time.</pre>
</blockquote>
<p>On April 18th, 2014, 3:24 p.m. CEST, <b>Cristian Oneț</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry if I offended you, I know to well how one feels about his work made voluntarily in his free time. I'm just asking that you never stop learning and improving the work you do. I even have the same critical view of my own code that I wrote back when I started contributing to kmymoney. I did ask for a rewrite but didn't say when so whenever you feel like it seems fine. Meanwhile we can leave this patch in "suspension" if it's too much.</pre>
</blockquote>
<p>On April 18th, 2014, 3:38 p.m. CEST, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, your criticism was valid, if a little brusque.
The patch is needed, so must go forward.
> - try to use the available space as uniformly as possible (1 page with 2 combos vs. 1 page with 10 combos)
I split up the wizard pages by logical function, and obviously some are much simpler than others. The investment
page needed a lot of fields, others just a couple. Are you saying to combine some of the smaller pages, even though
they may have no logical connection?
> - now we have a dialog (QWizard) inside another dialog (CSVDialog - former widget) which seems a bad idea to me.
Can you expand on this? I'm unclear.
</pre>
</blockquote>
<p>On April 20th, 2014, 1:31 p.m. CEST, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've made some small changes to the various UIs, using one or two vertical spacers to avoid having all the widgets in a clump with empty space below. Also, on the Banking wizard page, I've set a minimum width on all the combos, which allows them to shrink and remain visible, in order to reduce the overall width of the UI, to help on smaller screen displays. I won't set any fixed sizes.</pre>
</blockquote>
<p>On May 6th, 2014, 9:37 p.m. CEST, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've reduced the overall width, closer to its original value, in order to allow use on smaller screens.
I've removed the inheritance from QDialog, replacing it with QWidget. I hadn't realised QWizard itself inherits
from QDialog. I'm suspecting that that was actually the cause of some of the difficulties on different distros.
One thing I'd like opinions on is the use of resize(int, int). I'm trying to keep the UI appearance 'tidy',
avoiding the clipping of row height, athough obviously the user may choose to resize the plugin and please himself
about the appearance. Anyway, I start off with a display of ten rows, which looks OK until the user back-tracks
and loads another file with different column widths. This can result in the appearance/disappearance of the
horizontal scroll bar, which in turn disrupts the table height and appearance. So, I've used a resize() to restore
the original ten row display. However, this may not be what the user would want. Up to now, I've allowed for
saving many user preferences, but haven't saved window size. So, I'm thinking to do that, and then the resize
I've adopted would be of the saved values.
Any opinions, anyone?
</pre>
</blockquote>
<p>On May 7th, 2014, 8:41 a.m. CEST, <b>Cristian Oneț</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Making the window size persistent would be very useful. Of course you would need to check that the saved size matched the available space on the desktop to avoid weird behavior when moving to a different resolution.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"...I start off with a display of ten rows..." How about not fixing it to n rows. Instead you could create the window with the default size. Then calculate how many rows are shown and shrink or enlarge the window in a way that no row is shown half. This could avoid some issues which will be introduced by a fixed number.
Also keep in mind that in near future high dpi displays will be common which will make the unit "pixel" useless for sizes.
In my opinion it has no benefit not to show rows partly. This can actually clarify that there is more in the view than you can see directly (e.g. Mac OS X has no scroll bars anymore to indicate that).</pre>
<br />
<p>- Christian</p>
<br />
<p>On April 17th, 2014, 11:23 p.m. CEST, Cristian Oneț wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney and Allan Anderson.</div>
<div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated April 17, 2014, 11:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove fixed layout values from the CSV importer UI.
Also removed a lot of code (a lot still remains) that I think should
not be in there (like UI control size fine tuning).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For me the importer looks/feel almost like without this.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/csvimport/bankingwizardpage.ui <span style="color: grey">(d2179bff0504a67a22efbb364f90e089443d8239)</span></li>
<li>kmymoney/plugins/csvimport/completionwizardpage.ui <span style="color: grey">(99db07576265b68c764308bbb3da3cae38b151bd)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.h <span style="color: grey">(6716ca412db036384d9d8d65f0d1ab40efbe443f)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.cpp <span style="color: grey">(3ab7f9537acdb369b0c5b781827564e30d9ad396)</span></li>
<li>kmymoney/plugins/csvimport/csvdialog.ui <span style="color: grey">(36e7fd51159a1f7391394b5f00bc22387b0bd8f5)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterplugin.h <span style="color: grey">(d2d2f6ca9aeea0709512afcffbad17abea6a315a)</span></li>
<li>kmymoney/plugins/csvimport/csvimporterplugin.cpp <span style="color: grey">(602b4d924c8afc0b34819e47b03b88776319bf0c)</span></li>
<li>kmymoney/plugins/csvimport/introwizardpage.ui <span style="color: grey">(9bd29f5f4339add8790e032f5613ec46c675634d)</span></li>
<li>kmymoney/plugins/csvimport/investmentwizardpage.ui <span style="color: grey">(3744963e5e9a91ad36b8d0fa78839b296c5810f8)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(d9df90d6b9a6500b499e52ccb3e8734d163765eb)</span></li>
<li>kmymoney/plugins/csvimport/lines-datewizardpage.ui <span style="color: grey">(fb10a0e228d7bdee9ca1162edcd0d4b69225d68b)</span></li>
<li>kmymoney/plugins/csvimport/separatorwizardpage.ui <span style="color: grey">(30b2dc7b22ad24b7b2df96332deb25f9c8c76b89)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117620/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>