<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116819/">https://git.reviewboard.kde.org/r/116819/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 8d507513c17b70c7de0828eb63da20998e52a2bd by Christian Dávid to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On May 5th, 2014, 2:38 p.m. UTC, Christian David wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Christian David.</div>
<p style="color: grey;"><i>Updated May 5, 2014, 2:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added support for SQLCipher database driver in KMyMoney
Database backend supports SQLCipher driver. Added a new method to
KMyMoney's SQL driver which stores information if a password is
supported.
Also a new QSQLDriver for SQLCipher was introduced.
This is still work in progress as some features are missing (e.g. encrypt not encrypted database and vice versa, change password). But install is hard so only sophisticated users and engaged package maintainer can do that. I do not think this will be useful in near future. However I wanted to shared my code.
How to install/use this patch:
1) You need SQLCipher, http://sqlcipher.net , build and install it (to my knowledge it is not packed in any major distribution).
2) Get the qt source code (or just the one for QSQLiteDriver) and build it (needed as this will create the necessary folder hierarchy).
3) If you do not install to default location, enable CMake to find these folders (SQLCipher install folders, Qt source folder, Qt build folder).
4) Create KMyMoney with ENABLE_SQLCIPHER=ON (default is off)
Forgot: I have no clue how secure SQLCipher is! Just wanted to see if I can get it running.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opened, changed, closed and reopend a (manualy created) encrypted database file.
Performance to be tested...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/sqlcipher/tests/sqlcipherdrivertest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/sqlcipher/tests/sqlcipherdrivertest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(83a699b960b568f44e04b5801511da91dbda188e)</span></li>
<li>kmymoney/dialogs/kgeneratesqldlg.cpp <span style="color: grey">(856b457f3bc862ccd376a0f6bb43f02d92128fc8)</span></li>
<li>kmymoney/dialogs/kselectdatabasedlg.cpp <span style="color: grey">(a43dfc7c2494d025a4c48082cfd30b6394585dd4)</span></li>
<li>kmymoney/mymoney/storage/mymoneydbdriver.h <span style="color: grey">(8c8f84b5dcaca124fd3a59a59ac1e2e9637c6eba)</span></li>
<li>kmymoney/mymoney/storage/mymoneydbdriver.cpp <span style="color: grey">(c2219ef4c239ba350e3e7767c607afc9d7b41254)</span></li>
<li>kmymoney/plugins/CMakeLists.txt <span style="color: grey">(4e5e0740d54c8ba8db7587accb2a3c2fe565dc89)</span></li>
<li>kmymoney/plugins/sqlcipher/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/sqlcipher/cmake/modules/FindQSQLiteSource.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/sqlcipher/cmake/modules/FindSQLCipher.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/sqlcipher/qsqlcipherdriverplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/sqlcipher/qsqlcipherdriverplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/sqlcipher/sqlcipherdriver.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/sqlcipher/sqlcipherdriver.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/sqlcipher/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/sqlcipher/tests/sqlcipherdriverinstalltest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/sqlcipher/tests/sqlcipherdriverinstalltest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116819/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>