<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<div class="moz-cite-prefix">On 21/04/2014 4:25 AM, Allan wrote:<br>
</div>
<blockquote cite="mid:5354180B.1050404@gmail.com" type="cite">On
20/04/14 13:44, Chris wrote:
<br>
<blockquote type="cite">Hi Allan
<br>
<br>
Unfortunately this is not a solution. You should be able to
update the
<br>
amount using the bulk edit feature.
<br>
</blockquote>
<br>
When you say "You should be able to update the amount using the
bulk edit feature.", do you mean that it is supposed or stated to,
or do you mean "It would be useful if it did"? My immediate
thought the other day was, "Why would anyone want to do that?".
With just a quick look, I can't see any relevant code.
<br>
</blockquote>
<br>
That was my first thought too. but I can see the need for editing
amounts even in multiple edits.<br>
<br>
The code inside the <font face="Courier New, Courier, monospace">"if
(category_label) {</font>" is all relevant to editing the amount.
The code is run regardless of whether it is a new transaction,
multiple edit or single edit. So it is definitely needed. <br>
<br>
silently discarding value changes just because its in multiple edit
mode will probably have unintended side effects.<br>
<br>
<blockquote cite="mid:5354180B.1050404@gmail.com" type="cite">
<br>
<blockquote type="cite">The problem seems to be that the val
field is not checked whether it
<br>
has changed or not. It is cast to a Mymoneymoney object and as
it is an
<br>
empty string that object returns a 0
<br>
</blockquote>
<br>
I would suspect that it is not checked because it is not expected
to change,
<br>
but the devs really need to pronounce here.
<br>
</blockquote>
Yes<br>
<br>
<blockquote cite="mid:5354180B.1050404@gmail.com" type="cite">
<br>
<blockquote type="cite">The object probably should have a "NaN"
test, it does not appear to have
<br>
such a test. Failing that the text field should be checked
before the
<br>
MyMoneymoney object is instantiated and used.
<br>
</blockquote>
<br>
<blockquote type="cite">What is confusing is for some reason
<br>
StdTransactionEditor::slotUpdateCategory tests for the existence
of the
<br>
category label "if (categoryLabel)" and skips updating the value
if it
<br>
exists. It seems that that may have been a kludge fix for some
other
<br>
issue. The fact that the two types of editing, inline and using
the
<br>
form, have two different program paths says to me there are
bigger issues.
<br>
<br>
</blockquote>
<br>
Again, I'm not an expert, but comparing the transaction form with
the register fields, one has an Amount field, and the other has
Payment and Deposit, so the processing needs are somewhat
different. My deduction was that testing the Category label was a
way of determining which to use. Possibly the devs can
clarify/contradict.
<br>
</blockquote>
<br>
As stated above the same code runs whenever there is an edit
(including new transaction) so my guess is that test determines
whether its an inline edit or using the form. Why there is a
difference between the two editing methods I don't know<br>
<br>
Some advice from the devs certainly would help.<br>
<br>
<blockquote cite="mid:5354180B.1050404@gmail.com" type="cite">
<br>
<blockquote type="cite">Lastly when editing multiple transactions
if you select a category that
<br>
has a tax auto split on it, it silently fails to add the tax
split. That
<br>
is pretty crazy. If you rely on this software to do your annual
taxes
<br>
and it silently discards taxes, then you may have problems with
your tax
<br>
office. At the very least it should issue a warning. preferably
it
<br>
should create the split properly. I don't know if I want a stint
in jail
<br>
due to a software bug.
<br>
<br>
<br>
Chris
<br>
</blockquote>
<br>
This last paragraph needs dev. input.
<br>
</blockquote>
<br>
Only to say yes we need an alert at the very minimum. It is a major
failing to silently bypass tax allocations. To get more traction on
this I'll submit it as a bug.<br>
<br>
<br>
Chris<br>
<br>
<blockquote cite="mid:5354180B.1050404@gmail.com" type="cite">
<br>
Allan
<br>
<br>
<br>
<blockquote type="cite">On 17/04/2014 8:38 AM, allan wrote:
<br>
<blockquote type="cite"><a class="moz-txt-link-freetext" href="https://bugs.kde.org/show_bug.cgi?id=333498">https://bugs.kde.org/show_bug.cgi?id=333498</a>
<br>
<br>
--- Comment #3 from allan <a class="moz-txt-link-rfc2396E" href="mailto:agander93@gmail.com"><agander93@gmail.com></a> ---
<br>
On 16/04/14 13:01, Chris wrote:
<br>
<blockquote type="cite"><a class="moz-txt-link-freetext" href="https://bugs.kde.org/show_bug.cgi?id=333498">https://bugs.kde.org/show_bug.cgi?id=333498</a>
<br>
<br>
Bug ID: 333498
<br>
Summary: bulk edit actions results in amount of
transaction
<br>
being zeroed
<br>
</blockquote>
I have a potential fix for this, which appears to do the
necessary,
<br>
without any apparent harmful effects.
<br>
<br>
In void StdTransactionEditor::slotUpdateCategory(const
QString& id),
<br>
circa line 1543, there is an updateAmount(val), which now I
execute only
<br>
if (!isMultiSelection().
<br>
<br>
I don't know if there may be a better way/place to do this.
<br>
<br>
I notice also, that Buy and Sell activities have a similar
problem if a
<br>
fee account is entered.
<br>
<br>
Allan
<br>
<br>
</blockquote>
<br>
<br>
<br>
<br>
_______________________________________________
<br>
KMyMoney-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:KMyMoney-devel@kde.org">KMyMoney-devel@kde.org</a>
<br>
<a class="moz-txt-link-freetext" href="https://mail.kde.org/mailman/listinfo/kmymoney-devel">https://mail.kde.org/mailman/listinfo/kmymoney-devel</a>
<br>
<br>
</blockquote>
_______________________________________________
<br>
KMyMoney-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:KMyMoney-devel@kde.org">KMyMoney-devel@kde.org</a>
<br>
<a class="moz-txt-link-freetext" href="https://mail.kde.org/mailman/listinfo/kmymoney-devel">https://mail.kde.org/mailman/listinfo/kmymoney-devel</a>
<br>
<br>
</blockquote>
<br>
</body>
</html>