<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117630/">https://git.reviewboard.kde.org/r/117630/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney and Skrooge.</div>
<div>By Christian David.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
alkimia
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a cmake package configuration file
This replaces the Find....cmake file. A user should not notice any
changes. But:
- CMAKE_PREFIX_PATH is honored now
- Users do not have to find GMP themselves (which was a bug)
- CMake users are not affected by a bug in PKG_CHECK_MODULES anymore
more info: http://www.cmake.org/Bug/view.php?id=8644
This may not work if your old Find… file is still installed.
Also this should stop messing things up if you have several versions of alkimia installed (so annoying!).
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed my systems FindLibAlkimia.cmake
Set CMAKE_PREFIX_PATH
make clean in KMyMoney
Compiled KMyMoney without setting ${GMP_LIBRARIES} anywhere in KMyMoney (=> it works)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libalkimia/CMakeLists.txt <span style="color: grey">(7676567)</span></li>
<li>libalkimia/FindLibAlkimia.cmake <span style="color: grey">(2c4ce1e)</span></li>
<li>libalkimia/LibAlkimiaConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117630/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>