<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110212/">https://git.reviewboard.kde.org/r/110212/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 18th, 2014, 10:38 p.m. PDT, <b>Cristian Oneț</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was going to push this but before I did I gave it a try. I have the following remarks that can be seen in this video http://kmymoney2.sourceforge.net/screencasts/110212.ogv
If I try to merge two payees why can't I select one of them as the target? At leas that I what I expected from a merge function. Also the merge action is missing from the context menu. The merge dialog can be closed with enter without performing any action by typing a payee's name that is selected for merge.
Could you please address this issues? At least convince me that this is the right way it should work.
</pre>
</blockquote>
<p>On March 19th, 2014, 1:39 a.m. PDT, <b>Christian David</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"If I try to merge two payees why can't I select one of them as the target? At leas that I what I expected from a merge function." I think if you merge several payees you should be able to select only one of the selected ones to merge into.
If you have to select a different payee, it is a delete operation.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok. I see your point. So the list of possible payees should be those selected? I guess the user should be able to merge into a new payee as well.
And I will fix the context menu thing.</pre>
<br />
<p>- Felipe</p>
<br />
<p>On March 11th, 2014, 10:18 a.m. PDT, Felipe Tonello wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Felipe Tonello.</div>
<p style="color: grey;"><i>Updated March 11, 2014, 10:18 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">payee: Does not merge when payees are empty
When there is no transactions to be merged we don't need to merge. In fact if
we don't stop there the rest of the code will delete the payees, which is a
behavior for delete payees functionality.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
payee: Show transactions from multiple payees
This patch allow users to have see all transactions that they
will merge.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
payee: Added Payees Merge KButton
Adds a button next to the delete payee and enables it only when multiple
payees are selected.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
payee: Added payee_merge KAction
Added KAction to the context menu and connected to the slotPayeeMerge().
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
payee: Added support to Merge Payees
This patch implements the opeartion to merge payees. This is done by reusing
the payee delete slot, modifying it to support merge operation and add support
to it in KPayeeReassignDlg dialog.
The main difference between delete a payee and merging a payee is that when
merging the user can merge to a new payee. So the modification was done to
support this use-case.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
payee: change slotPayeeNew(...) to return boolean value
This is usefull if the user of that function wants to know if the user created
a new payee or not.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
payee: Make PayeeReassignDlg support other operations then delete
This is useful so it can be implemented a merge opration and maybe others in
future as well.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
payee: Better explanation when deleting payee
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Normal UI test going trough all the possible options of users input.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/kpayeereassigndlg.h <span style="color: grey">(a348d2b9fdc68a7c56a616a862a3373ef35aa0ba)</span></li>
<li>kmymoney/dialogs/kpayeereassigndlg.cpp <span style="color: grey">(8bdb25c0b3478c42715fac9f052903ed45b3614c)</span></li>
<li>kmymoney/dialogs/kpayeereassigndlgdecl.ui <span style="color: grey">(2cf563d4ea755e8d89ff2587fa677f14453cbaa5)</span></li>
<li>kmymoney/kmymoney.h <span style="color: grey">(56e0bd6a3de42bdaa3fbb2f8586495cbb4d555ca)</span></li>
<li>kmymoney/kmymoney.cpp <span style="color: grey">(6b96b9790d0ee5b5d34e6cfd382b03e9a103c9e6)</span></li>
<li>kmymoney/kmymoneyui.rc <span style="color: grey">(65afc920cef7091e3138c9acf75f73ec96929445)</span></li>
<li>kmymoney/views/kpayeesview.h <span style="color: grey">(c747e691f6509c7bf60201dfb3cc77e9f939a7c5)</span></li>
<li>kmymoney/views/kpayeesview.cpp <span style="color: grey">(7252241886e05f00555d16dc1388b9d6ecef36a2)</span></li>
<li>kmymoney/views/kpayeesviewdecl.ui <span style="color: grey">(6efb2ae5f94383851ee2ab15da36187b7079815a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110212/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>