<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115302/">https://git.reviewboard.kde.org/r/115302/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 1dede8b9dfb550b3a26e4fc0ade208788c877b2c by Allan Anderson to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On January 24th, 2014, 6:24 p.m. UTC, Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2014, 6:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319801">319801</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If a user's sequence of check numbers is broken by, say 'ATM' or an invoice number such as 'No 123-001 ABC', the next check number produced will be '1', entries containing alpha or punctuation characters not being saved.
The fix corrects this by saving the complete entry, and uses any entered numeric part to calculate the next number in sequence. If an existing numeric entry is edited, this entry will be taken into account for the next number.
There are some quirks. If the entry which led to the current 'next number' is deleted, it is not possible to revert to the previous, now forgotten, 'next number', so the produced 'next number' is likely to leave a 'gap', and may need editing. Also, there is no check that a new 'next number' does not already exist. For instance, if there is the erroneous sequence 23,23,24, the 'next number' will be the expected 25. However, if the user corrects the error by changing a 23 to 22, the new 'next number' will be 23, which also already exists. These issues, which exist also in the current release, also have been fixed, but are not included in this Review, for clarity. They will be submitted separately later.
The values in the unit test which are not purely numeric can now be used, and produce correct 'next numbers'.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Numerous manual test cases run. Unit tests run.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/kmymoneyutils.cpp <span style="color: grey">(7058557)</span></li>
<li>kmymoney/kmymoneyutils.h <span style="color: grey">(f64a55e)</span></li>
<li>kmymoney/dialogs/transactioneditor.cpp <span style="color: grey">(26e7672)</span></li>
<li>kmymoney/dialogs/transactioneditor.h <span style="color: grey">(25705a0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115302/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>