<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114767/">https://git.reviewboard.kde.org/r/114767/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2014, 10:06 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated as per review. One more thing is missing however, if I edit a loan that has been closed, the finish button is throwing an exception because the loan's schedule is invalid or something. I guess I need to change what happens in the finish a bit also.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=257619">257619</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add ability to modify loan institution attribute.
Add a new choice to editselectionwizardpage to modify only loan attributes.
Add a new loanattributes page to modify just institution for now, will add other attributes next.
BUG:257619</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It works here to set and to show the current institution.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/wizards/newloanwizard/CMakeLists.txt <span style="color: grey">(939d569c2bba56ccfd3c9d6b28f8b90d414b9332)</span></li>
<li>kmymoney/wizards/newloanwizard/editselectionwizardpage.cpp <span style="color: grey">(e8cf0353a6aa357f6fc3d818aa3819aa13cf25c5)</span></li>
<li>kmymoney/wizards/newloanwizard/editselectionwizardpagedecl.ui <span style="color: grey">(2e482c47f9a3642a880f0dcb047ca577c6e0446c)</span></li>
<li>kmymoney/wizards/newloanwizard/keditloanwizard.cpp <span style="color: grey">(5590a359ffc16c92fc3dc24b6484aac1180b1507)</span></li>
<li>kmymoney/wizards/newloanwizard/knewloanwizard.h <span style="color: grey">(6b3f049912605f4f9cb0e78ee83b14e2767586b8)</span></li>
<li>kmymoney/wizards/newloanwizard/knewloanwizarddecl.ui <span style="color: grey">(831d85ce388b51a904c76cd998f54ca6a099b347)</span></li>
<li>kmymoney/wizards/newloanwizard/loanattributeswizardpage.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/wizards/newloanwizard/loanattributeswizardpage.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/wizards/newloanwizard/loanattributeswizardpagedecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114767/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>