<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/113427/">https://git.reviewboard.kde.org/r/113427/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 2nd, 2014, 12:19 a.m. UTC, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've noticed a potential problem. When making a multi-edit, the memo field appears cleared. If any other edit is made, and the edit is entered, the original memos are cleared too, which is undesirable.
So, what I've done is remove the initial clearing of the memo fields, so their original content is maintained. As it happens, I made this suggestion in the review - "As with all editing of multiple items, all fields appear as blank initially. This has been retained here with multiple memo editing, but if desired, this could be changed and the field could be left showing previous content, which could be more intuitive for a user wanting to have an empty field."
I hope this is acceptable. It also avoids the requirement for a user who wants an empty memo, to have to enter a character into the empty memo field in order to delete it to trigger a connect.</pre>
</blockquote>
<p>On January 2nd, 2014, 7:10 a.m. UTC, <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not sure, if that is a good and practical solution. Let's say you have the following scenario:
- User selects two transactions containing different memo content
- User inadvertently changes the memo field and uses 'Undo' to undo the change
- Now he changes another field and enters the transactions
What happens to the memo content of the other transaction? Is it changed? It shouldn't. That is why I think leaving the field blank in the first place is the better choice. We can add a "What's this?" or "Tooltip" to the memo edit field which contains the hint that deleting the contents is achieved by adding a single blank.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let's say I have two transactions, and do a multi-edit on them, to add a memo comment of "Memo". OK so far.
Then I edit transaction A and add to the memo string "MemoB", so A now has "MemoMemoA", then change B to "MemoMemoB".
Then I do another multi-edit, and remove the second string. Interestingly, both keep their first string.
Next I repeat the above, except I change my mind and do an undo then enter. So now they are back to "MemoMemoA" and "MemoMemoB".
This time, I repeat the above, but, without entering, I now edit the date jointly, then enter. The memos still show "MemoMemoA" and "MemoMemoB", so there appears to be no adverse effect.
I'll do some more playing about. Assuming nothing seems amiss, am I OK still to Ship?</pre>
<br />
<p>- Allan</p>
<br />
<p>On October 24th, 2013, 11:06 p.m. UTC, Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2013, 11:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=289351">289351</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There was a previous fix for this problem - Git commit 9485826cfb50816d2df4dac9709b4beb255b8b75 by Cristian One?. Unfortunately, this was inadvertently disabled when BUG:311481 REVIEW:107714 was committed. This is now fixed.
This review adds the same capability for investment transactions.
In addition, there have been requests that when clearing the memo field, it should when required be empty rather that containing a blank character. It is necessary to enter a character in the memo field in order to signal that an edit has occurred, but now that character may then be deleted to leave the field empty, if that is what is required.
With investment transactions, it is always necessary to enter the security name as well. This requirement could probably be removed, but it is probably sensible to be editing just a single security.
As with all editing of multiple items, all fields appear as blank initially. This has been retained here with multiple memo editing, but if desired, this could be changed and the field could be left showing previous content, which could be more intuitive for a user wanting to have an empty field.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Numerous groups of investment and checking transactions entered and edited correctly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/investactivities.h <span style="color: grey">(aa4800f)</span></li>
<li>kmymoney/dialogs/investactivities.cpp <span style="color: grey">(e4760e5)</span></li>
<li>kmymoney/dialogs/investtransactioneditor.h <span style="color: grey">(20e3819)</span></li>
<li>kmymoney/dialogs/investtransactioneditor.cpp <span style="color: grey">(805bd8d)</span></li>
<li>kmymoney/dialogs/transactioneditor.h <span style="color: grey">(f07dafb)</span></li>
<li>kmymoney/dialogs/transactioneditor.cpp <span style="color: grey">(71d94ec)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/113427/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>