<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114352/">http://git.reviewboard.kde.org/r/114352/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">PS. There is one other point to comment upon.
After a transaction had been edited, the space occupied by the buttons, now closed, was not being released. In my original patch, I had dealt with this, but was unhappy with the method. Now, I've added a call to Register::resize() at the end of KGlobalLedgerView::slotLeaveEditMode(), to deal with this.</pre>
<br />
<p>- Allan Anderson</p>
<br />
<p>On December 8th, 2013, 6:19 p.m. UTC, Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney and Cristian Oneț.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated Dec. 8, 2013, 6:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312816">312816</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch extends the code of REVIEW: 112989, and as I cannot add a patch to Cristian's review request, I have raised a new request.
a) When an account is loaded, the columns for the kMyMoneyEdit fields have extra white-space, to allow for the calculator and date buttons, but these buttons won't appear until editing starts. This happens because m_usedWithEditor was being enabled in KGlobalLedgerView ctor. I've changed this so m_usedWithEditor is enabled instead in KGlobalLedgerView::startEdit() and reset in KGlobalLedgerView::slotLeaveEditMode().
b) When a transaction is opened for editing, the above columns are widened for the buttons. However, this window widening is not helped by potentially surplus white-space appearing in the Description column. This can frequently happen if the memo text is wide and possibly originally multi-line. When not editing, the multi-lines are combined into a wider field, but the multi-lines are restored when editing but the Details column does not notice this, so retains its full width. I've remedied this by reducing the width to that of the widest sub-string.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Much resizing of many checking and investment accounts, both while in edit mode and not.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/views/kgloballedgerview.cpp <span style="color: grey">(000393c)</span></li>
<li>kmymoney/widgets/register.cpp <span style="color: grey">(56bf46d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114352/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>