<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113011/">http://git.reviewboard.kde.org/r/113011/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 12th, 2013, 8:58 a.m. CET, <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113011/diff/2/?file=212553#file212553line2786" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/mymoney/mymoneyfile.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2786</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">category</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="s">"VatAmount"</span><span class="p">).</span><span class="n">toLower</span><span class="p">()</span> <span class="o">!=</span> <span class="n">QString</span><span class="p">(</span><span class="s">"net"</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I know it's not your code, but since we change it we might also improve it, so these constructs should use QLatin1String() to encapsulate string constants that don't contain only ASCII characters.
It's a minor improvement and I leave it up to you if you want to apply it, as it does not change the functionality at all.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are
grep -rn 'QString("' * | grep -v "%" | grep -v "+" | wc -l
335
similar strings in kmymoney source. May be better handled by a separate bug/review/patch ?
</pre>
<br />
<p>- Ralf</p>
<br />
<p>On November 12th, 2013, 12:59 p.m. CET, Ralf Habacker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney and Cristian Oneț.</div>
<div>By Ralf Habacker.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2013, 12:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=241322">241322</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add VAT split to file import.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. created new kmymoney file using skr03 standard accounts
2. enable "VAT account" account 1775 "Umsatzsteuer 19%" and entered 19 as vat percents
3. added account 1775 as automatic vat assignment accounts to account 8400 "Erlöse"
4. added payee "Warenverkauf" with auto assignment to account 8400
5. imported some transactions from csv file for account 1200 "Bankkonto" using the payee defined in step 4.
date,nr,expense,income,payee
14.02.2012,2,,"259,99",Warenverkauf
25.03.2012,3,,"49,99",Warenverkauf
25.06.2012,4,,"709,99",Warenverkauf
Afterwards ledger contains transactions with correct vat split.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/converter/mymoneystatementreader.cpp <span style="color: grey">(f41b0cf)</span></li>
<li>kmymoney/dialogs/transactioneditor.cpp <span style="color: grey">(71d94ec)</span></li>
<li>kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(af0c6fb)</span></li>
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(ff7302c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113011/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>