<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112989/">http://git.reviewboard.kde.org/r/112989/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, that looks good for the number and detail columns.
I'm still thinking about users with small screens and the excess width of several other columns. Any objections to me looking into this?
Also, I think I'd found a couple of bunches of code that served no apparent purpose (duplication).</pre>
<br />
<p>- Allan Anderson</p>
<br />
<p>On September 29th, 2013, 11:37 a.m. UTC, Cristian Oneț wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2013, 11:37 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312816">312816</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Improve the resizing of the register and the transaction form.
The transaction form was not correctly resizing the Value2 column
when the data of the KMyMoneyEdit exceeded the size of the widget.
The size of the push button (when present) was not considered when
the width was computed based on the cell text.
The same issues were fixed when for the inline transaction editor.
The register resizing was improved in the following ways:
- the number fields is no longer limited
- the details column can no longer be shrinked to a size smaller then
it's needed to render the data it contains
BUG: 312816</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ledger resize with/without the transaction form with multiple account types.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/widgets/kmymoneydateinput.cpp <span style="color: grey">(856efaa9ddffcec7440cf3530349568d2c789333)</span></li>
<li>kmymoney/widgets/register.h <span style="color: grey">(50ce7598783b49197de6acf4859a0fbd7c5c8962)</span></li>
<li>kmymoney/widgets/register.cpp <span style="color: grey">(d5dd63951d35b7098c0797fe64f10baf07a77fe1)</span></li>
<li>kmymoney/widgets/transactionform.cpp <span style="color: grey">(642e98f97eb98a14676186c296c1b27972f195cd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112989/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>