<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112885/">http://git.reviewboard.kde.org/r/112885/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now that this review has been inadvertently posted to group kmymoney and not only to Jack I would be happy to get feedback from core developers whether the approach I have chosen here is acceptable. Please see my question at the end of the description.</pre>
<br />
<p>- Marko Käning</p>
<br />
<p>On October 4th, 2013, 3:45 p.m. UTC, Marko Käning wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney and Jack Ostroff.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated Oct. 4, 2013, 3:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmymoney
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is an attempt of implementing an extended online balance highlighting in ledger view.
Three configuration options below "/Preferences/Ledger/Highlight (non-matching) online balance" are available:
'disable' - no highlighting
'strict' - highlight always if online and file balance don't match
'relaxed' - highlight with orange if online and file balance don't match, but cleared and online balance coincide
highlight only in red if cleared and online balance also don't match
---
To achieve the functionality I have to intercept in KGlobalLedgerView::updateSummaryLine()
the account's cleared balance in kgloballedgerview.cpp using the new method Register::setClearedBalance().
In Register::addGroupMarkers() I then fetch the online balance using Register::setOnlineBalance().
In GroupMarker::paintRegisterCell() I then use Register::hasEqualOnlineAndClearedBalances() to decide
which colors to use for highlighting the group marker.
My question: Is this approach acceptable, or should the functionality be hidden in class MyMoneyFile,
just like in case of MyMoneyFile::hasMatchingOnlineBalance()?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build, install, ran fine.
Config options get saved/restored as needed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.reviewboardrc <span style="color: grey">(7ed8df159b8e4a8af81a3fe9b360e940bce548cc)</span></li>
<li>kmymoney/dialogs/settings/ksettingsregisterdecl.ui <span style="color: grey">(049a985eb84707e0bce60a3c90206e948ff7ccec)</span></li>
<li>kmymoney/kmymoney.kcfg <span style="color: grey">(7a582fd4cbfbf657c0f2e5d3c9a3a1f20b0c939a)</span></li>
<li>kmymoney/tips <span style="color: grey">(ab0a720bacad41c4efbbe390bbc2d4e33c498bc3)</span></li>
<li>kmymoney/views/kgloballedgerview.cpp <span style="color: grey">(000393cc150162eb4d954ae1dcbd7fdee68e60d0)</span></li>
<li>kmymoney/widgets/register.h <span style="color: grey">(50ce7598783b49197de6acf4859a0fbd7c5c8962)</span></li>
<li>kmymoney/widgets/register.cpp <span style="color: grey">(d5dd63951d35b7098c0797fe64f10baf07a77fe1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112885/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>