<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112364/">http://git.reviewboard.kde.org/r/112364/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 25th, 2013, 3:21 a.m. UTC, <b>Cristian Oneț</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would not ship this patch. I'll elaborate a bit more my comments at https://bugs.kde.org/show_bug.cgi?id=312816#c6 and I'll base my arguments on this recording I made http://kmymoney2.sourceforge.net/screencasts/112364.ogv about how this patch behaves.
1. It breaks with the current behavior of the application (auto resizing columns after data has been entered to fit the entered data)
2. It introduces bugs, I mean, setting a maxWidth of "9,999,999.00 " for the amount fields!? This is exactly what was hurting the number column and the fix should be all about removing a limitation not adding new ones</pre>
</blockquote>
<p>On September 25th, 2013, 10:48 a.m. UTC, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You've concentrated on forms mode, where there is not much wrong.
1. Depending on content, there was some clipping.
2. There already was in Thomas's implementation a width restriction for the number column, so I eased it substantially.
The existing excessive width of some columns can result in clipping elsewhere. There are still problems with non/unnecessary appearance of investment widgets.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I know that the problem with unnecessary widgets is still there, I thought you are working on that (see the discussion with me, the patch I sent you, your discussion with David). We should still fix that issue. I thought that this review request (patch) only handles the number column issue (BUG 312816) at least the latest version of the patch.
I just tried to show that the patch does more damage than good, I agree that there are some issues now but they should be fixed in a proper way so that we don't break current behavior. I'm sure that all those issues that you've observed with the investment editor without the transaction form can be fixed while keeping the current behavior of the transaction form.
With the patch I attached to BUG 312816 I agree that the first time a long check number is entered the user will not see it entirely, but, after the transaction is entered the width of that column is adjusted to fit the entered data, thus next time the user will not have this issue when entering a similar check number. I prefer this, you could say, sloppy implementation because of it's very small incidence to the one which makes the column size change at each key press (with a big incidence).</pre>
<br />
<p>- Cristian</p>
<br />
<p>On September 25th, 2013, 10:48 a.m. UTC, Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2013, 10:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If I choose to use a complex system for check numbers, such that the whole number is not visible,
the only way I have available is to stretch the whole window. However, even that doesn't help,
as the whole of the increase is grabbed by the Details column. I accept that it is likely that that
column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the
width of the Balance column, when that column may be likely to have the greatest value? Ditto for
the Date.
This fix allows modification of column widths, but also resizes the individual columns to more suitable widths.
I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that.
I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide()
methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered
more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved
the issue, although with some complication.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extensive editing of sample files, and changing back and forth between different activity types, which tended to show
problem areas. atype run.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312816">312816</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=322768">322768</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/transactioneditor.h <span style="color: grey">(f07dafb)</span></li>
<li>kmymoney/dialogs/transactioneditor.cpp <span style="color: grey">(39049cf)</span></li>
<li>kmymoney/views/kgloballedgerview.cpp <span style="color: grey">(2057b47)</span></li>
<li>kmymoney/widgets/register.h <span style="color: grey">(eebe78d)</span></li>
<li>kmymoney/widgets/register.cpp <span style="color: grey">(1bdf5bd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112364/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>