<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112364/">http://git.reviewboard.kde.org/r/112364/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 10th, 2013, 7:20 a.m. UTC, <b>Cristian Oneț</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112364/diff/1/?file=185610#file185610line204" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/dialogs/investactivities.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Activity::preloadAssetAccount(void)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">204</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QTimer</span><span class="o">::</span><span class="n">singleShot</span><span class="p">(</span><span class="mi">150</span><span class="p">,</span> <span class="n">fees</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">hide</span><span class="p">()));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also I don't see a reason why the timeouts passed to QTimer::signleShot vary that much, 5, 100, 150, is there a reason for it?</pre>
</blockquote>
<p>On September 10th, 2013, 9:57 a.m. UTC, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can't give an explanation for why the should differ. Having previously encountered this same problem some why ago, Thomas advised using the timer. As before, I started off using a small value, but found that this didn't work in the new near-identical code area. So, I started to increase the delay. In come cases, I had to use a large delay in order to see that the widget did finally respond. I then started to reduce the value until failure, and then back-off. Having got a particular widget finally responding, after further work I found that the problem was still sometimes there and had to make further adjustments. In many cases, this 'tuning' was revisited.
When finally all appeared OK, I then found that during actual window resizing, some widgets would flicker quite badly during their repositioning, depending upon the speed of mouse movement. The only way I could resolve that was by zeroing the widget height instead of hiding it.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There must be a simpler way to do this. If this approach is so timing dependent it could be that the solution does not even work on a slower or faster machine/system.</pre>
<br />
<p>- Cristian</p>
<br />
<p>On August 29th, 2013, 5:12 p.m. UTC, Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2013, 5:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If I choose to use a complex system for check numbers, such that the whole number is not visible,
the only way I have available is to stretch the whole window. However, even that doesn't help,
as the whole of the increase is grabbed by the Details column. I accept that it is likely that that
column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the
width of the Balance column, when that column may be likely to have the greatest value? Ditto for
the Date.
This fix allows modification of column widths, but also resizes the individual columns to more suitable widths.
I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that.
I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide()
methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered
more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved
the issue, although with some complication.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extensive editing of sample files, and changing back and forth between different activity types, which tended to show
problem areas. atype run.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312816">312816</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=322768">322768</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/investactivities.cpp <span style="color: grey">(50f33ed)</span></li>
<li>kmymoney/dialogs/investtransactioneditor.h <span style="color: grey">(3e62c2a)</span></li>
<li>kmymoney/dialogs/investtransactioneditor.cpp <span style="color: grey">(e9f87fb)</span></li>
<li>kmymoney/dialogs/transactioneditor.h <span style="color: grey">(f07dafb)</span></li>
<li>kmymoney/dialogs/transactioneditor.cpp <span style="color: grey">(39049cf)</span></li>
<li>kmymoney/views/kgloballedgerview.h <span style="color: grey">(04a6303)</span></li>
<li>kmymoney/views/kgloballedgerview.cpp <span style="color: grey">(78d98b2)</span></li>
<li>kmymoney/widgets/register.h <span style="color: grey">(eebe78d)</span></li>
<li>kmymoney/widgets/register.cpp <span style="color: grey">(1bdf5bd)</span></li>
<li>kmymoney/widgets/transactionform.cpp <span style="color: grey">(642e98f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112364/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>