<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112364/">http://git.reviewboard.kde.org/r/112364/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If I choose to use a complex system for check numbers, such that the whole number is not visible,
the only way I have available is to stretch the whole window. However, even that doesn't help,
as the whole of the increase is grabbed by the Details column. I accept that it is likely that that
column is going to need to be the widest. Then, why are the Payment and Deposit columns twice the
width of the Balance column, when that column may be likely to have the greatest value? Ditto for
the Date.
This fix allows modification of column widths, but also resizes the individual columns to more suitable widths.
I found that Thomas had started to implement something similar some while ago, so I have built upon and expanded that.
I found that the edit widgets were particularly troublesome, in failing to appear/disappear with the show() and hide()
methods, which I'd previously found when last in this area. Then, when the screen was being resized, they flickered
more than acceptable. Eventually, where necessary, I resorted to zeroing/resetting the height instead, which resolved
the issue, although with some complication.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Extensive editing of sample files, and changing back and forth between different activity types, which tended to show
problem areas. atype run.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312816">312816</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=322768">322768</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/investactivities.cpp <span style="color: grey">(50f33ed)</span></li>
<li>kmymoney/dialogs/investtransactioneditor.h <span style="color: grey">(3e62c2a)</span></li>
<li>kmymoney/dialogs/investtransactioneditor.cpp <span style="color: grey">(e9f87fb)</span></li>
<li>kmymoney/dialogs/transactioneditor.h <span style="color: grey">(f07dafb)</span></li>
<li>kmymoney/dialogs/transactioneditor.cpp <span style="color: grey">(39049cf)</span></li>
<li>kmymoney/views/kgloballedgerview.h <span style="color: grey">(04a6303)</span></li>
<li>kmymoney/views/kgloballedgerview.cpp <span style="color: grey">(78d98b2)</span></li>
<li>kmymoney/widgets/register.h <span style="color: grey">(eebe78d)</span></li>
<li>kmymoney/widgets/register.cpp <span style="color: grey">(1bdf5bd)</span></li>
<li>kmymoney/widgets/transactionform.cpp <span style="color: grey">(642e98f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112364/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>