<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112026/">http://git.reviewboard.kde.org/r/112026/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 17th, 2013, 5:31 p.m. UTC, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not a cmake specialist, which is why I don't see why this change is needed.
Tested on Mac OS X 10.6.8 anyway with 0304cfbf94ae620b02017dbba88db7385690eca0 and this patch applied.
All I can say after all is that KMM still works as it did before.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have to correct my review, since for some reason I hadn't actually built the sources I thought I had.
So, I tried again (f74364cd45a3cd81426bdb3e7e073989978abe2f + patch) and have to report that the correct application icon does NOT APPEAR in MacOSX' dock anymore!
So, beware committing this patch as is.</pre>
<br />
<p>- Marko</p>
<br />
<p>On August 14th, 2013, 8:22 p.m. UTC, Yury Kudryashov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Yury Kudryashov.</div>
<p style="color: grey;"><i>Updated Aug. 14, 2013, 8:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">
This way icons are not mixed with sources in `ls` output.
git pull kde:clones/kmymoney/kudryashov/kmymoney move-icons
to see moved files not as removed & created</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">cmake ..; make; make instal</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/CMakeLists.txt <span style="color: grey">(593cda911041ba74303405b042465e66095269b1)</span></li>
<li>kmymoney/hi128-app-kmymoney.png <span style="color: grey">(8831c8984fe043f6fa95c68c5502931009b743fc)</span></li>
<li>kmymoney/hi128-mimetypes-application-x-kmymoney.png <span style="color: grey">(b7b07754c92fc257419ff26d343d899e44666e27)</span></li>
<li>kmymoney/hi16-app-kmymoney.png <span style="color: grey">(602dfe2c6138925bfab0f658ef590d7796fdb4d9)</span></li>
<li>kmymoney/hi16-mimetypes-application-x-kmymoney.png <span style="color: grey">(6ba3367e88a18b272a48c2dd4b19103b040047cc)</span></li>
<li>kmymoney/hi22-mimetypes-application-x-kmymoney.png <span style="color: grey">(9e2a8a463d8e60ade5d952a08fe33d27c2c692a8)</span></li>
<li>kmymoney/hi32-app-kmymoney.png <span style="color: grey">(2c094bd6e3a6b8838eeb4c316e6b4af76e97baef)</span></li>
<li>kmymoney/hi32-mimetypes-application-x-kmymoney.png <span style="color: grey">(13a8bd2a9e8c106098cfef0178130c1de84eb9f8)</span></li>
<li>kmymoney/hi48-app-kmymoney.png <span style="color: grey">(5d3dd78a57dca266b5da5153a036783b25f243a1)</span></li>
<li>kmymoney/hi48-mimetypes-application-x-kmymoney.png <span style="color: grey">(d362bf40b93549ac331f282e9bf337784370bf23)</span></li>
<li>kmymoney/hi64-app-kmymoney.png <span style="color: grey">(c92938c8659e835b1941dfdf1072daacfa4cc008)</span></li>
<li>kmymoney/hi64-mimetypes-application-x-kmymoney.png <span style="color: grey">(f045903d8b91d88db677d768ff1f6fb633230bed)</span></li>
<li>kmymoney/icons/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/hi128-app-kmymoney.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/hi128-mimetypes-application-x-kmymoney.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/hi16-app-kmymoney.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/hi16-mimetypes-application-x-kmymoney.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/hi22-mimetypes-application-x-kmymoney.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/hi32-app-kmymoney.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/hi32-mimetypes-application-x-kmymoney.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/hi48-app-kmymoney.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/hi48-mimetypes-application-x-kmymoney.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/hi64-app-kmymoney.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/hi64-mimetypes-application-x-kmymoney.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/lo16-app-kmymoney.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/icons/xdg/lo32-app-kmymoney.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/kmymoney_wizard.png <span style="color: grey">(be61ab7d4696c40edfe08b64b373b2c1c1a0aa08)</span></li>
<li>kmymoney/lo16-app-kmymoney.png <span style="color: grey">(5a245b70bfde4eff384b56b027837ceec710459f)</span></li>
<li>kmymoney/lo32-app-kmymoney.png <span style="color: grey">(2c094bd6e3a6b8838eeb4c316e6b4af76e97baef)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112026/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>