<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108666/">http://git.reviewboard.kde.org/r/108666/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit ace6e9657a5bef10f3f3ca9b69afdae9df7ec209 by Cristian Oneț to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On February 7th, 2013, 6:46 p.m. UTC, Cristian Oneț wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2013, 6:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This removes usage of the deprecated StdAddressBook API. Using the guide provided at http://techbase.kde.org/Development/AkonadiPorting/AddressBook. Unfortunately this does not work if you don't have nepomuk enabled (as I later found out). I don't have nepomuk enabled because it keeps eating my CPU/memory. I'll file a bug report later when I'll have time for this. Anyway from my POV it's really stupid that this does not work without nepomuk (since nepomuk can be disabled from systemsettings). ANy other ideas how should we handle this? Should we ignore the warning for now?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Version1: This query made virtuoso eat one of my processor's core so no testing was done.
Version2: The user's data is loaded as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(93af070)</span></li>
<li>kmymoney/CMakeLists.txt <span style="color: grey">(7fec1a9)</span></li>
<li>kmymoney/dialogs/knewfiledlg.h <span style="color: grey">(cb2a153)</span></li>
<li>kmymoney/dialogs/knewfiledlg.cpp <span style="color: grey">(c7b3ecb)</span></li>
<li>kmymoney/wizards/newuserwizard/knewuserwizard.cpp <span style="color: grey">(d8a4ab2)</span></li>
<li>kmymoney/wizards/newuserwizard/knewuserwizard_p.h <span style="color: grey">(9ec49d0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108666/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>