<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi,<br>
<br>
Last time I tried to push to git I ended up creating a new branch
and I don't want to do that again so I can just check I am doing
the right thing.<br>
I have a branch at the moment called bug317682 which has the patch
committed to it.<br>
I am planning to do:<br>
git checkout master<br>
git pull -r<br>
git checkout bug317682<br>
git rebase master<br>
git push origin bug317682<br>
Would that be correct?<br>
<br>
TIA,<br>
<br>
Ian<br>
<br>
Alvaro Soliverez wrote:<br>
</div>
<blockquote cite="mid:20130603013539.20000.39764@vidsolbach.de"
type="cite">
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table style="border: 1px #c9c399 solid;" bgcolor="#f9f3c9"
cellpadding="8" width="100%">
<tbody>
<tr>
<td> This is an automatically generated e-mail. To reply,
visit: <a moz-do-not-send="true"
href="http://git.reviewboard.kde.org/r/109918/">http://git.reviewboard.kde.org/r/109918/</a>
</td>
</tr>
</tbody>
</table>
<br>
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It looks fine to me. Go ahead and push it to master.</pre>
<br>
<p>- Alvaro</p>
<br>
<p>On April 8th, 2013, 10:27 p.m. UTC, Ian Neal wrote:</p>
<table style="background-image:
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png');
background-position: left top; background-repeat: repeat-x;
border: 1px black solid;" bgcolor="#fefadf" cellpadding="8"
cellspacing="0" width="100%">
<tbody>
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Ian Neal.</div>
<p style="color: grey;"><i>Updated April 8, 2013, 10:27
p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Description </h1>
<table style="border: 1px solid #b8b5a0"
bgcolor="#ffffff" cellpadding="10" cellspacing="0"
width="100%">
<tbody>
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On KDE 4.10.1 setting of a holiday region to United Kingdom no longer makes public holidays non-processing days.
This patch:
* Makes use of new HolidayRegion API to generate list of regions with languages for holiday region selector in schedule settings pane.
I believe the new API was added in KDE 4.5
</pre>
</td>
</tr>
</tbody>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Testing </h1>
<table style="border: 1px solid #b8b5a0"
bgcolor="#ffffff" cellpadding="10" cellspacing="0"
width="100%">
<tbody>
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested against recent git master compiled on KDE 4.10.1
Needs to be tested against other KDE versions 4.5 upwards but I only have access to 4.10.1</pre>
</td>
</tr>
</tbody>
</table>
<div style="margin-top: 1.5em;"> <b style="color:
#575012; font-size: 10pt; margin-top: 1.5em;">Bugs:
</b> <a moz-do-not-send="true"
href="http://bugs.kde.org/show_bug.cgi?id=317682">317682</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top:
1.5em;">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/settings/ksettingsschedules.cpp <span
style="color: grey">(b57d5dd)</span></li>
</ul>
<p><a moz-do-not-send="true"
href="http://git.reviewboard.kde.org/r/109918/diff/"
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
</blockquote>
<br>
</body>
</html>