<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109918/">http://git.reviewboard.kde.org/r/109918/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From Bugzilla, -
>From Dave Houlden (In reply to comment #2)
> Just to mention that I'm on KDE 4.6.5 with KMyMoney holiday calendar set to
> United Kingdom and my schedules for 1st April have moved to 2nd April as I
> expect. I'm not sure why but I don't see the problem described by Ian.
I'm on KDE 4.9.5 and, like Dave, get the correct results, without the patch. I've not taken particular note in the past of this feature's working.</pre>
<br />
<p>- Allan</p>
<br />
<p>On April 8th, 2013, 10:27 p.m. UTC, Ian Neal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Ian Neal.</div>
<p style="color: grey;"><i>Updated April 8, 2013, 10:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On KDE 4.10.1 setting of a holiday region to United Kingdom no longer makes public holidays non-processing days.
This patch:
* Makes use of new HolidayRegion API to generate list of regions with languages for holiday region selector in schedule settings pane.
I believe the new API was added in KDE 4.5
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested against recent git master compiled on KDE 4.10.1
Needs to be tested against other KDE versions 4.5 upwards but I only have access to 4.10.1</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=317682">317682</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/settings/ksettingsschedules.cpp <span style="color: grey">(b57d5dd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109918/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>