<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110587/">http://git.reviewboard.kde.org/r/110587/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 24th, 2013, 10:31 a.m. UTC, <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110587/diff/1/?file=145747#file145747line392" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/views/kgloballedgerview.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">signals:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">392</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1">/// void m_parent ( m_parent arg1 );</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">??? This seems to be a leftover</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Will go ahead.
Yes, I noticed that line in passing, nothing to do with my topic, and it seemed to be unused, but I didn't want just to remove it as it wasn't mine, so just disabled it.</pre>
<br />
<p>- Allan</p>
<br />
<p>On May 21st, 2013, 11:21 p.m. UTC, Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated May 21, 2013, 11:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When I found recently that I couldn't edit multiple investment transactions, and started to investigate, I discovered this old bug, which had resulted in the disabling of the feature. I fixed the reported problem and re-enabled that code. That fix was committed as 3f45cfc6996f9c2cd2fa01dd0232051c50075651 on 2 April. When I investigated further, I discovered there were some additional issues, which Thomas felt should be left in abeyance pending a re-write of the Ledger code.
I then found that there was a potential danger of a user editing unlike investment types and not noticing that one of the types could get changed inadvertently without his noticing, particularly if a number of transactions were being edited at once. This has therefore now been fixed and editing of unlike investment types is no longer possible.
It was also noticed that the tooltips in this part of /kmymoney/views/kgloballedgerview.cpp did not work as I expected, in that there was no tooltip visible on the transaction in question, although it was found that the tooltips were attached to the edit button. It was felt that this wasn't very helpful, as the user might have attempted the edit from the context menu or by double-click. So, I have added code to display error information at the transaction position. I haven't done this for every error message, where I was unable to determine how to produce the error condition. However, I have covered the mixed investment types situation, multiple splits, and flagging any attempt to edit where a closed account was involved. The original code for tooltips has been left in place, however.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ensured that attempts to edit unlike items is prevented, and also to create or edit transactions where a closed account is involved. Unit test run without error.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/kmymoney.cpp <span style="color: grey">(063f8b5)</span></li>
<li>kmymoney/views/kgloballedgerview.h <span style="color: grey">(0041ea2)</span></li>
<li>kmymoney/views/kgloballedgerview.cpp <span style="color: grey">(8a2c592)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110587/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>