<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110212/">http://git.reviewboard.kde.org/r/110212/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 3rd, 2013, 1:53 p.m. CEST, <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wonder, why we need a merge payee feature if the delete payee feature has basically the same functionality. Maybe, you can provide some insights why you developed this patch in the first place. Or am I missing something completely here?</pre>
</blockquote>
<p>On May 3rd, 2013, 7 p.m. CEST, <b>Felipe Tonello</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's true, but for the user stand point of view delete to merge doesn't make sense.
I added this feature because it is useful for me, perhaps for other users as well. Sometimes I have to merge Payees because I wrote them wrong or because they are the same and I didn't know.
Maybe we can just change delete to delete/merge. But still, for in terms of UX I prefer having different buttons for each functionality.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Agreed, but can we share the code of both somehow? After all, we have a list of payees that need to be deleted and the transactions referenced by them to be changed to a single payee. The UI might be different, but the works are the same, right? I think it would definitely a plus to have a single place to maintain the logic instead of two. What do you think? (Just saw that you mentioned that yourself in the FIXME section). Would a MyMoneyFile::mergeAndDeletePayees(MyMoneyPayee, QList<MyMoneyPayee>) be of help?</pre>
<br />
<p>- Thomas</p>
<br />
<p>On April 27th, 2013, 5:20 a.m. CEST, Felipe Tonello wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Felipe Tonello.</div>
<p style="color: grey;"><i>Updated April 27, 2013, 5:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Patch 1: Implements the actual merge operation.
Patches 2 and 3: Implements KAction and context menu option[2] and a button in
payees view[3].
Patch 4: This patch might be controversial because I believe the functionality
provided by this patch was not implemented because of some reason that it's
not documented.
TODO: improve user experience (UX) by:
- Use a dialog similar to the KPayeeReassignDlg. Probably just making it more generic.
- Improve slotPayeeNew() to not to ask if user wants to create new payee or not.
FIXME: Too much duplicated code from slotPayeeDelete() and others. The way that the
MyMoney* Objects are designed requires too much repeated work, so I believe using
generic helper functions might be a good idea.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/kmymoney.h <span style="color: grey">(22515f4e842a48645ea82ee50d3bd735927b87d5)</span></li>
<li>kmymoney/kmymoney.cpp <span style="color: grey">(063f8b5a0357e39de2482a93abbd4cb33f869e19)</span></li>
<li>kmymoney/kmymoneyui.rc <span style="color: grey">(f35364158b77af1ee066d779b59ded7578f5c8f2)</span></li>
<li>kmymoney/views/kpayeesview.h <span style="color: grey">(1fb9633f96355e0cd0da231afc8384bc48f01ca6)</span></li>
<li>kmymoney/views/kpayeesview.cpp <span style="color: grey">(97a3f93ab034707db30fb3085c79b06e7ca8f1ca)</span></li>
<li>kmymoney/views/kpayeesviewdecl.ui <span style="color: grey">(8d9c0083780c5cfb31dc3a237aa1deac1c708cca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110212/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>