<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109043/">http://git.reviewboard.kde.org/r/109043/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 29th, 2013, 10:52 a.m. UTC, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've noticed there is a clash between this proposed fix and the fix issued for Bug 311481. I'm in the process of testing a revision.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because of this clash, and because the resulting main changes are in the code covered by Bug 311481, the overall fix will be in that review.
See https://git.reviewboard.kde.org/r/107714/ .
</pre>
<br />
<p>- Allan</p>
<br />
<p>On March 8th, 2013, 12:05 a.m. UTC, Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated March 8, 2013, 12:05 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When not using the transaction form, it is possible to enter just an amount, and immediately the Enter button becomes enabled. This is not the case when using the transaction form. The Enter button only becomes enabled when other fields are added.
Some other discrepancies also were noticed, both when using the transaction form, and when not.
1a) Enter a payee. That's OK.
1b) Now enter a single character in the memo. Enter enabled.
2a) Enter a memo character. That's OK.
2b) Now enter a payee. That's still OK.
2c) Now enter another memo character. Enter enabled.
3a) Enter an account. Enter enabled.
4a) Enter a tag. Enter enabled.
Also, when using the transaction form and doing a multi-transaction edit, on attempting to enter an amount, it was not accepted unless the amount was negative.
In the same area, the tabs are not enabled.
Investment entry seems OK. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Performed numerous edits both with and without the transaction form, and single and multiple transactions. Imports of QIF and CSV files done.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=314955">314955</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=316111">316111</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/investactivities.cpp <span style="color: grey">(6035d11)</span></li>
<li>kmymoney/dialogs/transactioneditor.cpp <span style="color: grey">(a6d7432)</span></li>
<li>kmymoney/widgets/register.cpp <span style="color: grey">(c167bcd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109043/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>