<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109803/">http://git.reviewboard.kde.org/r/109803/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 21st, 2013, 3:39 p.m. CEST, <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109803/diff/3/?file=139981#file139981line218" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/plugins/csvexport/csvwriter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">218</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">str</span> <span class="o">+=</span> <span class="n">QString</span><span class="p">(</span><span class="s">"R"</span><span class="p">)</span> <span class="o">%</span> <span class="n">QString</span><span class="p">(</span><span class="sc">','</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Such constructs are the reason for so many performance problems (though not here I assume): why don't you simply write
str += QLatin1String("R,");
</pre>
</blockquote>
<p>On April 21st, 2013, 4:56 p.m. CEST, <b>Allan Anderson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I picked up on QStringBuilder recently and had the impression it improved performance. I'm not saying what I've done is correct, and I bow to your experience.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just read http://blog.qt.digia.com/blog/2011/06/13/string-concatenation-with-qstringbuilder/ to get an idea of what QStringBuilder is and tries to achieve. Makes sense, but why would you want to concatenate to strings which are known at compile-time during run-time? That does not sound right to me.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On April 19th, 2013, 7:52 p.m. CEST, Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated April 19, 2013, 7:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add CSV export capability. Modify existing KMyMoney File menu in order to make menu item positions more logical.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Exported numerous checking and investment CSV files, and then imported into KMyMoney via CSV import (discovering a few minor issues in the existing KMyMoney accounts in the process.)
Ran astyle and Krazy2.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=317614">317614</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/plugins/CMakeLists.txt <span style="color: grey">(81ca458)</span></li>
<li>kmymoney/plugins/csvexport/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvexportdlg.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvexportdlg.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvexportdlgdecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvexporterplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvexporterplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvwriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvwriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/kmm_csvexport.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/kmm_csvexport.rc <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109803/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>