<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109803/">http://git.reviewboard.kde.org/r/109803/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 19th, 2013, 6:48 a.m. UTC, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Alan,
I have build, installed and run KMM4 with your patch on Mac OS X Snow Leopard.
I was able to successfully export CSV for a few accounts in a breeze (account and category contents).
Looks like this is already ripe to be shipped.
Greets,
Marko</pre>
</blockquote>
<p>On April 19th, 2013, 6:52 a.m. UTC, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only remark I forgot to post just now is that by default the file path in the export dialog is set to "/home/aga/Documents/KMM/csv/csvexport.csv" which should rather be the user's home directory.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Many thanks for testing, Marko.
That path was getting picked up from the resource file, on which Cristian has commented too.</pre>
<br />
<p>- Allan</p>
<br />
<p>On March 30th, 2013, 6:42 p.m. UTC, Allan Anderson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Allan Anderson.</div>
<p style="color: grey;"><i>Updated March 30, 2013, 6:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add CSV export capability. Modify existing KMyMoney File menu in order to make menu item positions more logical.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Exported numerous checking and investment CSV files, and then imported into KMyMoney via CSV import (discovering a few minor issues in the existing KMyMoney accounts in the process.)
Ran astyle and Krazy2.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=317614">317614</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/kmymoneyui.rc <span style="color: grey">(f353641)</span></li>
<li>kmymoney/plugins/CMakeLists.txt <span style="color: grey">(81ca458)</span></li>
<li>kmymoney/plugins/csvexport/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvexportdlg.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvexportdlg.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvexportdlgdecl.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvexporterplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvexporterplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvexporterrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvwriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/csvwriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/kmm_csvexport.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/kmm_csvexport.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvexport/ui_csvexportdlgdecl.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kmymoney/plugins/csvimport/investprocessing.cpp <span style="color: grey">(07d4d82)</span></li>
<li>kmymoney/plugins/csvimport/kmm_csvimport.rc <span style="color: grey">(d678169)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109803/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>