<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108666/">http://git.reviewboard.kde.org/r/108666/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108666/diff/3/?file=112950#file112950line69" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">69</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">FIND_PACKAGE</span><span class="p">(</span><span class="s">KDE4</span> <span class="s">4.<span class="hl">4</span>.0</span> <span class="s">REQUIRED</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">69</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">FIND_PACKAGE</span><span class="p">(</span><span class="s">KDE4</span> <span class="s">4.<span class="hl">6</span>.0</span> <span class="s">REQUIRED</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This definitively makes it suitable only for master. It can't go into stable.
It was expected, as it's not a critical feature, but worth keeping in mind.
I'll check later with my setup as it's running Akonadi without issues.</pre>
</div>
<br />
<p>- Alvaro</p>
<br />
<p>On February 7th, 2013, 6:43 p.m. UTC, Cristian Oneț wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Cristian Oneț.</div>
<p style="color: grey;"><i>Updated Feb. 7, 2013, 6:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This removes usage of the deprecated StdAddressBook API. Using the guide provided at http://techbase.kde.org/Development/AkonadiPorting/AddressBook. Unfortunately this does not work if you don't have nepomuk enabled (as I later found out). I don't have nepomuk enabled because it keeps eating my CPU/memory. I'll file a bug report later when I'll have time for this. Anyway from my POV it's really stupid that this does not work without nepomuk (since nepomuk can be disabled from systemsettings). ANy other ideas how should we handle this? Should we ignore the warning for now?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This query made virtuoso eat one of my processor's core so no testing was done.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(93af070)</span></li>
<li>kmymoney/CMakeLists.txt <span style="color: grey">(7fec1a9)</span></li>
<li>kmymoney/dialogs/knewfiledlg.h <span style="color: grey">(cb2a153)</span></li>
<li>kmymoney/dialogs/knewfiledlg.cpp <span style="color: grey">(c7b3ecb)</span></li>
<li>kmymoney/wizards/newuserwizard/knewuserwizard.cpp <span style="color: grey">(d8a4ab2)</span></li>
<li>kmymoney/wizards/newuserwizard/knewuserwizard_p.h <span style="color: grey">(9ec49d0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108666/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>