<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108150/">http://git.reviewboard.kde.org/r/108150/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 19th, 2013, 6:39 a.m. UTC, <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have a added a few naming issues. No big deal. Otherwise, it looks good to me.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll take care of these naming issues before I commit this patch.
Anyway, on my TODO is still the splitting up of the corresponding test into separate test functions, as suggested by Lukazs.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 19th, 2013, 6:39 a.m. UTC, <b>Thomas Baumgart</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108150/diff/8/?file=107793#file107793line2933" style="color: black; font-weight: bold; text-decoration: underline;">kmymoney/mymoney/mymoneyfile.cpp</a>
<span style="font-weight: normal;">
(Diff revision 8)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2933</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QList</span><span class="o"><</span><span class="n">MyMoneyTransaction</span><span class="o">></span> <span class="n">transactions</span> <span class="o">=</span> <span class="n">transactionList</span><span class="p">(</span><span class="n">filter</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not sure if any optimizer reduces that to
return transactionList(filter).count();
which is all we need. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is what I get if I try it without a QList inserted:
/Users/marko/WC/GIT/kmymoney.homeview-additional_columns/kmymoney/mymoney/mymoneyfile.cpp: In member function ‘int MyMoneyFile::countTransactionsWithSpecificReconcileState(const QString&, MyMoneyTransactionFilter::stateOptionE) const’:
/Users/marko/WC/GIT/kmymoney.homeview-additional_columns/kmymoney/mymoney/mymoneyfile.cpp:2933: error: ‘((const MyMoneyFile*)this)->MyMoneyFile::transactionList’ does not have class type
make[2]: *** [kmymoney/mymoney/CMakeFiles/kmm_mymoney.dir/mymoneyfile.cpp.o] Error 1
make[1]: *** [kmymoney/mymoney/CMakeFiles/kmm_mymoney.dir/all] Error 2</pre>
<br />
<p>- Marko</p>
<br />
<p>On January 18th, 2013, 10:11 p.m. UTC, Marko Käning wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney and Łukasz Maszczyński.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated Jan. 18, 2013, 10:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch introduces 3 new columns in the accounts tables on KMM's homepage (similar to [1]) which will list the number of
a) not marked ('!M'),
b) "only" cleared ('C'),
c) as well as all not reconciled ('!R')
transactions for each specific account.
Every one of these columns can be individually switched on.
This information will give the user the chance to immediately spot accounts which might need to be looked after.
---
[1] "homepage: extend accounts table with additional columns to reflect online-status" https://git.reviewboard.kde.org/r/107364/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests and runs fine.
TODO:
- implement sub-tests as separate test-functions</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/settings/ksettingshomedecl.ui <span style="color: grey">(4cb36cced4801f5d6ecf35ef84f375a629cd8792)</span></li>
<li>kmymoney/kmymoney.kcfg <span style="color: grey">(a60ccad153385c961fa15c5b0964588c14e7ad89)</span></li>
<li>kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(0f114457877e6cebc44ce991741984643e409136)</span></li>
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(eb99876a924d13287f3d80786d2da6b05dfd3417)</span></li>
<li>kmymoney/mymoney/mymoneyfiletest.h <span style="color: grey">(5e397981c40eb006449fb73fd58a006b8fc16d82)</span></li>
<li>kmymoney/mymoney/mymoneyfiletest.cpp <span style="color: grey">(c831ad3586756b91469567dd934cbd0165df570d)</span></li>
<li>kmymoney/views/khomeview.cpp <span style="color: grey">(7da6980b866ff2523ddfb07e0826d3394d1b7157)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108150/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>