<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108150/">http://git.reviewboard.kde.org/r/108150/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney and Łukasz Maszczyński.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated Jan. 18, 2013, 9:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reworked patch according to Brendan's suggestions w.r.t. three new otp-in-configurable columns, so that the user can really choose what suits best.
(For some reason I suddenly can't add a new screenshot right now. Will try to deliver that in a second step.)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch introduces 3 new columns in the accounts tables on KMM's homepage (similar to [1]) which will list the number of
a) not marked ('!M'),
b) "only" cleared ('C'),
c) as well as all not reconciled
transactions for each specific account.
Every one of these columns can be individually switched on.
This information will give the user the chance to immediately spot accounts which might need to be looked after.
---
[1] "homepage: extend accounts table with additional columns to reflect online-status" https://git.reviewboard.kde.org/r/107364/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, tests and runs fine.
TODO:
- implement sub-tests as separate test-functions</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/settings/ksettingshomedecl.ui <span style="color: grey">(4cb36cced4801f5d6ecf35ef84f375a629cd8792)</span></li>
<li>kmymoney/kmymoney.kcfg <span style="color: grey">(a60ccad153385c961fa15c5b0964588c14e7ad89)</span></li>
<li>kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(0f114457877e6cebc44ce991741984643e409136)</span></li>
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(eb99876a924d13287f3d80786d2da6b05dfd3417)</span></li>
<li>kmymoney/mymoney/mymoneyfiletest.h <span style="color: grey">(5e397981c40eb006449fb73fd58a006b8fc16d82)</span></li>
<li>kmymoney/mymoney/mymoneyfiletest.cpp <span style="color: grey">(c831ad3586756b91469567dd934cbd0165df570d)</span></li>
<li>kmymoney/views/khomeview.cpp <span style="color: grey">(7da6980b866ff2523ddfb07e0826d3394d1b7157)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108150/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>