<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108398/">http://git.reviewboard.kde.org/r/108398/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">starDate (which should have been named startDate in the first place) is a left-over from early versions. The reconciliation must go beyond the last statement date to catch valid transactions that could have been happened between the last transaction on the statement and the statement date itself. This is sometimes the case for credit card statements.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On January 13th, 2013, 9:04 p.m. UTC, Łukasz Maszczyński wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Maszczyński.</div>
<p style="color: grey;"><i>Updated Jan. 13, 2013, 9:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When compiling from a clean workspace, there is a bunch of compilation warnings. Most of them seem pretty straighforward, but please note the fix for 'starDate' variable: as far as I understand, currently the reconcilation will be run from "the beginning", not from the date of last reconcilation, which I believe was the author's intent when he defined 'starDate' variable. Is that what is expected?
fixed warning: variable 'it' set but not used
fixed warning: variable 'previousFiscalYear' set but not used
fixed warning: variable 'temp' set but not used
fixed warning: variable 'entry' set but not used
fixed warning: variable 'calculatedField' set but not used
fixed warning: variable 'starDate' set but not used</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compile
make test</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/kmymoney.cpp <span style="color: grey">(70c642e55548b3435e1c46d99e4ad19adb5970bd)</span></li>
<li>kmymoney/plugins/kbanking/widgets/kbaccountlist.cpp <span style="color: grey">(f403228ec9e55ae4578b6d3f7219d02731a1d67f)</span></li>
<li>kmymoney/widgets/kmymoneydatetbl.cpp <span style="color: grey">(a0c560e1d74d9795e45d3289158de8d6c73e0509)</span></li>
<li>kmymoney/widgets/register.cpp <span style="color: grey">(a469e7a8deac95da737c0227bccba62a0a208efe)</span></li>
<li>kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp <span style="color: grey">(89916a273fc0c136c75373f0ace0e579fc0a930d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108398/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>