<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107619/">http://git.reviewboard.kde.org/r/107619/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 3rd, 2013, 6:55 p.m., <b>Łukasz Maszczyński</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good, the tests are getting more and more readable with every update.</pre>
</blockquote>
<p>On January 4th, 2013, 9:52 p.m., <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see now that also testTwoInstitutions() and testOneInstitution() are interfering, like my tests did before.
These two tests are inherently also used inside testAddAccounts(), which complicates things further.
I guess it looks like the tests would need a general overhaul independent of what I am trying to implement here and I'd suggest to ship this patch for now and open a new review for further changes to other tests, which will be in any case a quite extensive project...</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I understand. It sounds reasonable.</pre>
<br />
<p>- Łukasz</p>
<br />
<p>On January 3rd, 2013, 7:45 p.m., Marko Käning wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney and Łukasz Maszczyński.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2013, 7:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The homepage accounts tables now show a different icon if there are transactions for an account after the last online transaction - highlighting for the user the necessity to download transactions in order to verify the account status.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built and ran application and test cases successfully.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(c43977ce7413eee2bc1e0a841fa548314c71e9df)</span></li>
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(6640356d5e07152f8eb4aecff23d62ee8d853dbd)</span></li>
<li>kmymoney/mymoney/mymoneyfiletest.h <span style="color: grey">(5551fa94b6b34022c8e91c0301847d5479e6b1f2)</span></li>
<li>kmymoney/mymoney/mymoneyfiletest.cpp <span style="color: grey">(feb9d57ecd7156fc1eea189a905fa797aeae9183)</span></li>
<li>kmymoney/views/khomeview.cpp <span style="color: grey">(c79337176b7265cabe15cad4972bc719e797af7c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107619/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107619/s/948/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/01/KMM-online-status-icon3_400x100.png" style="border: 1px black solid;" alt="example for the 4 possible cases of online status" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>