<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108150/">http://git.reviewboard.kde.org/r/108150/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney and Łukasz Maszczyński.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2013, 12:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Desired functionality is there, so that people are invited to give it a try and let me know what they think.
Tests are still to be implemented.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Display the number of not reconciled transactions for every account on KMM's homepage</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch introduces new columns in the accounts tables on KMM's homepage (similar to [1]) which will list the number of not reconciled transactions for each specific account.
This information will give the user the chance to immediately spot accounts which aren't properly looked after.
---
[1] "homepage: extend accounts table with additional columns to reflect online-status" https://git.reviewboard.kde.org/r/107364/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds and runs fine.
TODO:
- implement tests for MyMoneyFile::countNotReconciledTransactions(const QString& accId)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/settings/ksettingshomedecl.ui <span style="color: grey">(4cb36cced4801f5d6ecf35ef84f375a629cd8792)</span></li>
<li>kmymoney/kmymoney.kcfg <span style="color: grey">(a60ccad153385c961fa15c5b0964588c14e7ad89)</span></li>
<li>kmymoney/mymoney/mymoneyfile.h <span style="color: grey">(c43977ce7413eee2bc1e0a841fa548314c71e9df)</span></li>
<li>kmymoney/mymoney/mymoneyfile.cpp <span style="color: grey">(6640356d5e07152f8eb4aecff23d62ee8d853dbd)</span></li>
<li>kmymoney/views/khomeview.cpp <span style="color: grey">(c79337176b7265cabe15cad4972bc719e797af7c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108150/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots (updated)</h1>
<div>
<a href="http://git.reviewboard.kde.org/r/108150/s/985/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/06/KMM-not-reconciled_400x100.png" style="border: 1px black solid;" alt="accounts tables with the additional column for the number of not reconciled transactions" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>