<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107759/">http://git.reviewboard.kde.org/r/107759/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 597c2b8ba69cd2cc9edef9c25fd7e414642ead8f by Lukasz Maszczynski to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 16th, 2012, 4:07 p.m., Łukasz Maszczyński wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KMymoney.</div>
<div>By Łukasz Maszczyński.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2012, 4:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When imported transactions are being matched with schedules and existing transactions, the payee of the imported transaction is disregarded.
Example:
1. Create a schedule with following parameters:
- named "Phone bill"
- payment to "Telefonica"
- amount: approximately 30 EUR
- date: 5th of every month
2. Import a transaction with the following parameters:
- payee: "FooMart"
- amount: 30.50 EUR
- date: 6th
Actual result: match
Expected result: no match, because the payees are known and mismatch.
This patch will allow a match of transactions if both refer to the same payee, or at least one of the transactions doesn't refer to any payee.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">make test
manual test of the case from the description
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmymoney/dialogs/transactionmatchfinder.h <span style="color: grey">(e819ad98a6a3d2d9493f21a11f5cbfa707140f3c)</span></li>
<li>kmymoney/dialogs/transactionmatchfinder.cpp <span style="color: grey">(cf326e9db480ac471eba96129c448e181ecbf97b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107759/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>